WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
57369
Rename BidiResolver::eor and sor to m_eor and m_sor to match modern style
https://bugs.webkit.org/show_bug.cgi?id=57369
Summary
Rename BidiResolver::eor and sor to m_eor and m_sor to match modern style
Eric Seidel (no email)
Reported
2011-03-29 11:49:26 PDT
Rename BidiResolver::eor and sor to m_eor and m_sor to match modern style
Attachments
Patch
(17.49 KB, patch)
2011-03-29 11:51 PDT
,
Eric Seidel (no email)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2011-03-29 11:51:15 PDT
Created
attachment 87380
[details]
Patch
Dimitri Glazkov (Google)
Comment 2
2011-03-29 11:53:06 PDT
Comment on
attachment 87380
[details]
Patch m_mmmm.
WebKit Commit Bot
Comment 3
2011-03-29 15:59:17 PDT
Comment on
attachment 87380
[details]
Patch Rejecting
attachment 87380
[details]
from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2 Last 500 characters of output: D at 811. Hunk #22 FAILED at 833. Hunk #23 FAILED at 849. Hunk #25 FAILED at 894. Hunk #26 succeeded at 908 with fuzz 1. Hunk #27 FAILED at 918. Hunk #28 FAILED at 933. 18 out of 28 hunks FAILED -- saving rejects to file Source/WebCore/platform/text/BidiResolver.h.rej patching file Source/WebCore/rendering/InlineIterator.h Hunk #1 succeeded at 247 (offset -1 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--..." exit_code: 1 Full output:
http://queues.webkit.org/results/8285514
WebKit Commit Bot
Comment 4
2011-03-29 23:24:50 PDT
Comment on
attachment 87380
[details]
Patch Clearing flags on attachment: 87380 Committed
r82395
: <
http://trac.webkit.org/changeset/82395
>
WebKit Commit Bot
Comment 5
2011-03-29 23:24:56 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug