Bug 57369 - Rename BidiResolver::eor and sor to m_eor and m_sor to match modern style
Summary: Rename BidiResolver::eor and sor to m_eor and m_sor to match modern style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on: 57367
Blocks:
  Show dependency tree / graph
 
Reported: 2011-03-29 11:49 PDT by Eric Seidel (no email)
Modified: 2011-03-29 23:24 PDT (History)
6 users (show)

See Also:

Attachments
Patch (17.49 KB, patch)
2011-03-29 11:51 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-03-29 11:49:26 PDT 
Rename BidiResolver::eor and sor to m_eor and m_sor to match modern style
Comment 1 Eric Seidel (no email) 2011-03-29 11:51:15 PDT 
Created attachment 87380 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-03-29 11:53:06 PDT 
Comment on attachment 87380 [details]
Patch

m_mmmm.
Comment 3 WebKit Commit Bot 2011-03-29 15:59:17 PDT 
Comment on attachment 87380 [details]
Patch

Rejecting attachment 87380 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2

Last 500 characters of output:
D at 811.
Hunk #22 FAILED at 833.
Hunk #23 FAILED at 849.
Hunk #25 FAILED at 894.
Hunk #26 succeeded at 908 with fuzz 1.
Hunk #27 FAILED at 918.
Hunk #28 FAILED at 933.
18 out of 28 hunks FAILED -- saving rejects to file Source/WebCore/platform/text/BidiResolver.h.rej
patching file Source/WebCore/rendering/InlineIterator.h
Hunk #1 succeeded at 247 (offset -1 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--..." exit_code: 1

Full output: http://queues.webkit.org/results/8285514
Comment 4 WebKit Commit Bot 2011-03-29 23:24:50 PDT 
Comment on attachment 87380 [details]
Patch

Clearing flags on attachment: 87380

Committed r82395: <http://trac.webkit.org/changeset/82395>
Comment 5 WebKit Commit Bot 2011-03-29 23:24:56 PDT 
All reviewed patches have been landed.  Closing bug.