Bug 57347 – [Snow Leopard WebKit2 Release Tests] fast/images/move-image-to-new-document.html timing out since r82087

• Status: RESOLVED
• Resolution: FIXED
• Component: Plug-ins

[Jessie Berlin]

http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r82085%20(10076)/results.html
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r82087%20(10077)/results.html

This, surprisingly, points to http://trac.webkit.org/changeset/82087 as the culprit.

Since it is just timing out and not flakey, we should probably land expected failing results.

[Jessie Berlin]

<rdar://problem/9202498>

[Adam Roben (:aroben)]

(In reply to comment #0)
> Since it is just timing out and not flakey, we should probably land expected failing results.

If it's timing out, we should skip it. Tests take a long time to time out, and it's better for everyone not to slow down the tests because of them.

[Jessie Berlin]

Added to the mac-wk2 Skipped list in http://trac.webkit.org/changeset/82292.

[Andy Estes]

The timeout is actually expected now after <http://trac.webkit.org/changeset/82001> and the test needs to be changed to behave correctly. It just so happened that <http://trac.webkit.org/changeset/82087> exposed it by correcting a MIME type registration issue between QuickTime and WebKit2.

I'll change the test to call setPluginsDisabled(), which will give the embed tag in this test its old image loading behavior. Unfortunately setPluginsDisabled isn't implemented in WebKit2's LayoutTestController, so it'll still have to be skipped until that bug is fixed.

[Andy Estes]

Sorry, I meant to say setPluginsEnabled(false). There is no such thing as setPluginsDisabled().

[Andy Estes]

Created attachment 87467 [details]
Patch

[Andy Estes]

Committed r82399: <http://trac.webkit.org/changeset/82399>

[Andy Estes]

https://bugs.webkit.org/show_bug.cgi?id=58593 tracks implementing layoutTestController.setPluginsEnabled() in WebKitTestRunner, which will allow us to un-skip this test and two others.