Bug 58593 - WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
Summary: WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Keywords: InRadar
: 87296 (view as bug list)
Depends on:
Reported: 2011-04-14 15:59 PDT by Andy Estes
Modified: 2012-05-30 10:29 PDT (History)
3 users (show)

See Also:

Patch (9.84 KB, patch)
2012-05-25 14:01 PDT, Marcelo Lira
no flags Details | Formatted Diff | Diff
Patch (10.41 KB, patch)
2012-05-28 09:17 PDT, Marcelo Lira
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2011-04-14 15:59:22 PDT
The following three tests are skipped because this method isn't implemented:


Implement the method so we can un-skip these tests.
Comment 1 Andy Estes 2011-04-14 15:59:39 PDT
Comment 2 Andy Estes 2011-04-14 16:09:31 PDT
Added this bug's URL to the Skipped list in <http://trac.webkit.org/changeset/83907>.
Comment 3 Marcelo Lira 2012-05-25 14:01:52 PDT
Created attachment 144144 [details]
Comment 4 Marcelo Lira 2012-05-25 14:07:25 PDT
*** Bug 87296 has been marked as a duplicate of this bug. ***
Comment 5 Darin Adler 2012-05-26 17:02:59 PDT
Comment on attachment 144144 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=144144&action=review

> Tools/ChangeLog:11
> +        (WTR):

Stray line that should be deleted. Better to write per-function comments, also.

> Tools/ChangeLog:13
> +        (LayoutTestController):

Another stray line that needs to be deleted. The script to prepare change logs doesn’t get them completely right, so the programmers has to do a bit of work.
Comment 6 Marcelo Lira 2012-05-28 09:17:20 PDT
Created attachment 144376 [details]
Comment 7 WebKit Review Bot 2012-05-30 10:29:48 PDT
Comment on attachment 144376 [details]

Clearing flags on attachment: 144376

Committed r118937: <http://trac.webkit.org/changeset/118937>
Comment 8 WebKit Review Bot 2012-05-30 10:29:53 PDT
All reviewed patches have been landed.  Closing bug.