RESOLVED FIXED Bug 58593
WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=58593
Summary WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
Andy Estes
Reported 2011-04-14 15:59:22 PDT
The following three tests are skipped because this method isn't implemented: platform/mac/plugins/disable-plugins.html fast/images/embed-image.html fast/images/move-image-to-new-document.html Implement the method so we can un-skip these tests.
Attachments
Patch (9.84 KB, patch)
2012-05-25 14:01 PDT, Marcelo Lira
no flags
Patch (10.41 KB, patch)
2012-05-28 09:17 PDT, Marcelo Lira
no flags
Andy Estes
Comment 1 2011-04-14 15:59:39 PDT
Andy Estes
Comment 2 2011-04-14 16:09:31 PDT
Added this bug's URL to the Skipped list in <http://trac.webkit.org/changeset/83907>.
Marcelo Lira
Comment 3 2012-05-25 14:01:52 PDT
Marcelo Lira
Comment 4 2012-05-25 14:07:25 PDT
*** Bug 87296 has been marked as a duplicate of this bug. ***
Darin Adler
Comment 5 2012-05-26 17:02:59 PDT
Comment on attachment 144144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144144&action=review > Tools/ChangeLog:11 > + (WTR): Stray line that should be deleted. Better to write per-function comments, also. > Tools/ChangeLog:13 > + (LayoutTestController): Another stray line that needs to be deleted. The script to prepare change logs doesn’t get them completely right, so the programmers has to do a bit of work.
Marcelo Lira
Comment 6 2012-05-28 09:17:20 PDT
WebKit Review Bot
Comment 7 2012-05-30 10:29:48 PDT
Comment on attachment 144376 [details] Patch Clearing flags on attachment: 144376 Committed r118937: <http://trac.webkit.org/changeset/118937>
WebKit Review Bot
Comment 8 2012-05-30 10:29:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.