Bug 56881 - Teach update-webkit about gyp
Summary: Teach update-webkit about gyp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 55018
  Show dependency treegraph
 
Reported: 2011-03-22 16:56 PDT by Eric Seidel (no email)
Modified: 2011-03-22 18:52 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.96 KB, patch)
2011-03-22 17:02 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-03-22 16:56:51 PDT
Teach update-webkit about gyp
Comment 1 Eric Seidel (no email) 2011-03-22 17:02:32 PDT
Created attachment 86547 [details]
Patch
Comment 2 Adam Barth 2011-03-22 17:03:42 PDT
Comment on attachment 86547 [details]
Patch

ok.
Comment 3 Adam Barth 2011-03-22 18:08:19 PDT
Comment on attachment 86547 [details]
Patch

Clearing flags on attachment: 86547

Committed r81735: <http://trac.webkit.org/changeset/81735>
Comment 4 Adam Barth 2011-03-22 18:08:23 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Mark Rowe (bdash) 2011-03-22 18:47:03 PDT
Comment on attachment 86547 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86547&action=review

> Tools/Scripts/generate-project-files:37
> +# This allows building from Source without a copy of Tools (as Apple's internal builds do).

Note that this doesn’t help our builds at all since the builds in question check out using “svn export”, not using any WebKit scripts.
Comment 6 Mark Rowe (bdash) 2011-03-22 18:48:05 PDT
In other words, that part of the comment is misleading as-is so I’m not sure why it’s present.
Comment 7 Adam Barth 2011-03-22 18:52:31 PDT
(In reply to comment #5)
> (From update of attachment 86547 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86547&action=review
> 
> > Tools/Scripts/generate-project-files:37
> > +# This allows building from Source without a copy of Tools (as Apple's internal builds do).
> 
> Note that this doesn’t help our builds at all since the builds in question check out using “svn export”, not using any WebKit scripts.
>
> In other words, that part of the comment is misleading as-is so I’m not sure why it’s present.

You obviously know more about the Apple internal build system than I do.  The comment is meant to explain that we have two scripts in order to make Source buildable without Tools.  As an example of such a situation, Tools is not an input into Apple's internal build system.  We can certainly update the comment to explain this more clearly.