Bug 56864 - Add the remaining steps to WebCore GYP build
Summary: Add the remaining steps to WebCore GYP build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 55018
  Show dependency tree / graph
 
Reported: 2011-03-22 14:41 PDT by Adam Barth
Modified: 2011-03-22 14:52 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.07 KB, patch)
2011-03-22 14:44 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-03-22 14:41:09 PDT 
Add the remaining steps to WebCore GYP build
Comment 1 Adam Barth 2011-03-22 14:44:39 PDT 
Created attachment 86510 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-03-22 14:47:47 PDT 
Comment on attachment 86510 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86510&action=review

> Source/WebCore/gyp/copy-inspector-resources.sh:8
> +rm -f "${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector/WebKit.qrc"

Seems ${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector wants to be a local variable. :)
Comment 3 Adam Barth 2011-03-22 14:48:56 PDT 
(In reply to comment #2)
> (From update of attachment 86510 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86510&action=review
> 
> > Source/WebCore/gyp/copy-inspector-resources.sh:8
> > +rm -f "${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector/WebKit.qrc"
> 
> Seems ${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector wants to be a local variable. :)

True.  I didn't write this script.  (It's hard-coded into the xcodeproj.)

I suspect once we have this stuff "out in the open", there are lots of things we can improve.
Comment 4 Adam Barth 2011-03-22 14:52:14 PDT 
Comment on attachment 86510 [details]
Patch

Clearing flags on attachment: 86510

Committed r81706: <http://trac.webkit.org/changeset/81706>
Comment 5 Adam Barth 2011-03-22 14:52:18 PDT 
All reviewed patches have been landed.  Closing bug.