Bug 56860 - WebCore GYP build should build without help from normal WebCore build
Summary: WebCore GYP build should build without help from normal WebCore build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 55018
  Show dependency tree / graph
 
Reported: 2011-03-22 13:38 PDT by Adam Barth
Modified: 2011-03-22 14:07 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.18 KB, patch)
2011-03-22 13:42 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (6.16 KB, patch)
2011-03-22 13:50 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-03-22 13:38:51 PDT 
WebCore GYP build should build without help from normal WebCore build
Comment 1 Adam Barth 2011-03-22 13:42:16 PDT 
Created attachment 86498 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-03-22 13:48:29 PDT 
Comment on attachment 86498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86498&action=review

OK.

> Source/WebCore/ChangeLog:15
> +        target, called "WebCore Support", which is less that aesthetically

"less that"
Comment 3 Eric Seidel (no email) 2011-03-22 13:49:02 PDT 
Comment on attachment 86498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86498&action=review

> Source/WebCore/gyp/WebCore.gyp:282
> +          'mac_bundle': 1,

This loks wrong.
Comment 4 Eric Seidel (no email) 2011-03-22 13:49:39 PDT 
Comment on attachment 86498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86498&action=review

> Source/WebCore/gyp/copy-forwarding-and-icu-headers.sh:4
> +rsync -aq --exclude ".svn" --exclude ".DS_Store" "$SRCROOT/../ForwardingHeaders" "$BUILT_PRODUCTS_DIR/$PRIVATE_HEADERS_FOLDER_PATH"
> +rsync -aq --exclude ".svn" --exclude ".DS_Store" "$SRCROOT/../icu" "$BUILT_PRODUCTS_DIR/$PRIVATE_HEADERS_FOLDER_PATH"

You might want to make the rsync command a variable if you add more of these...
Comment 5 Adam Barth 2011-03-22 13:50:32 PDT 
Created attachment 86500 [details]
Patch
Comment 6 Eric Seidel (no email) 2011-03-22 13:50:49 PDT 
Comment on attachment 86498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86498&action=review

> Source/WebCore/gyp/WebCore.gyp:150
> +          'inputs': [],
> +          'outputs': [],

Isn't [] the default here?
Comment 7 Adam Barth 2011-03-22 13:55:41 PDT 
> Isn't [] the default here?

Nope.  The property is required.  :(
Comment 8 Adam Barth 2011-03-22 14:07:32 PDT 
Comment on attachment 86500 [details]
Patch

Clearing flags on attachment: 86500

Committed r81695: <http://trac.webkit.org/changeset/81695>
Comment 9 Adam Barth 2011-03-22 14:07:36 PDT 
All reviewed patches have been landed.  Closing bug.