Bug 56802 – Clear autofilled flag when reseting a form

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ilya Sherman]

Clear autofilled flag when reseting a form

[Ilya Sherman]

Created attachment 86426 [details]
Patch

[Ilya Sherman]

Created attachment 86427 [details]
Patch

[James Robinson]

Comment on attachment 86427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86427&action=review

> LayoutTests/platform/chromium/fast/forms/reset-autofilled-expected.txt:5
> +This tests that a field's autofilled state is reverted when the form is reset. It can only be run using DumpRenderTree.
> +
> +PASS 1 is non-zero.
> +PASS 0 is 0
> +

why do we need this? this seems identical to the fallback expectation

> LayoutTests/platform/win/fast/forms/reset-autofilled-expected.txt:4
> +PASS 1 is non-zero.
> +FAIL 1 should be 0. Was 1.

why does this fail? is there a bug on file?

[Ilya Sherman]

(In reply to comment #3)
> (From update of attachment 86427 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86427&action=review
> 
> > LayoutTests/platform/chromium/fast/forms/reset-autofilled-expected.txt:5
> > +This tests that a field's autofilled state is reverted when the form is reset. It can only be run using DumpRenderTree.
> > +
> > +PASS 1 is non-zero.
> > +PASS 0 is 0
> > +
> 
> why do we need this? this seems identical to the fallback expectation

The fallback expectation -- at least for Windows and Linux -- is the Windows one, which is wrong in this case.

> > LayoutTests/platform/win/fast/forms/reset-autofilled-expected.txt:4
> > +PASS 1 is non-zero.
> > +FAIL 1 should be 0. Was 1.
> 
> why does this fail? is there a bug on file?

This fails because the relevant LayoutTestController method is not implemented: https://bugs.webkit.org/show_bug.cgi?id=55834

[Kent Tamura]

Comment on attachment 86427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86427&action=review

> LayoutTests/fast/forms/reset-autofilled.html:27
> +        shouldBe(stringify(countAutofilledElements()), '0');

Why stringify() is needed? 
shouldBe('countAutoFilledElements()', '0') doesn't work?

>>> LayoutTests/platform/win/fast/forms/reset-autofilled-expected.txt:4

>> 
>> why does this fail? is there a bug on file?
> 
> This fails because the relevant LayoutTestController method is not implemented: https://bugs.webkit.org/show_bug.cgi?id=55834

Could you implement it for Windows?

[Ilya Sherman]

Created attachment 86436 [details]
Patch

[Ilya Sherman]

(In reply to comment #5)
> Why stringify() is needed? 
> shouldBe('countAutoFilledElements()', '0') doesn't work?

Good point -- fixed.


> >>> LayoutTests/platform/win/fast/forms/reset-autofilled-expected.txt:4
> >> 
> >> why does this fail? is there a bug on file?
> > 
> > This fails because the relevant LayoutTestController method is not implemented: https://bugs.webkit.org/show_bug.cgi?id=55834
> 
> Could you implement it for Windows?

I'd like to, but I need to track down someone who can point me in the right direction.

[WebKit Commit Bot]

Comment on attachment 86436 [details]
Patch

Clearing flags on attachment: 86436

Committed r81652: <http://trac.webkit.org/changeset/81652>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/81652 might have broken SnowLeopard Intel Release (WebKit2 Tests)

[Adam Roben (:aroben)]

(In reply to comment #10)
> http://trac.webkit.org/changeset/81652 might have broken SnowLeopard Intel Release (WebKit2 Tests)

The test relies on LayoutTestController functionality that's unimplemented in WebKitTestRunner. I'll add it to the mac-wk2 Skipped file.

[Adam Roben (:aroben)]

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 86427 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=86427&action=review
> > > LayoutTests/platform/win/fast/forms/reset-autofilled-expected.txt:4
> > > +PASS 1 is non-zero.
> > > +FAIL 1 should be 0. Was 1.
> > 
> > why does this fail? is there a bug on file?
> 
> This fails because the relevant LayoutTestController method is not implemented: https://bugs.webkit.org/show_bug.cgi?id=55834

Bug 55834 is about layoutTestController.setValueForUser. We had no bug about layoutTestController.setAutofilled, so I filed one: bug 56828.

It turns out the Windows results are incorrect. I'll update them to match reality.