Bug 56828 - Implement layoutTestController.setAutoFilled in DRT on Windows
Summary: Implement layoutTestController.setAutoFilled in DRT on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Ilya Sherman
URL:
Keywords: InRadar, LayoutTestFailure, PlatformOnly
Depends on:
Blocks:
 
Reported: 2011-03-22 06:43 PDT by Adam Roben (:aroben)
Modified: 2011-03-24 22:06 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.91 KB, patch)
2011-03-23 14:49 PDT, Ilya Sherman
no flags Details | Formatted Diff | Diff
Patch (4.92 KB, patch)
2011-03-23 15:17 PDT, Ilya Sherman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-03-22 06:43:46 PDT
There are a few tests which rely on layoutTestController.setAutofilled. This function is unimplemented on Windows. We should implement it so we can run these tests!
Comment 1 Adam Roben (:aroben) 2011-03-22 07:54:38 PDT
<rdar://problem/9168468>
Comment 2 Ilya Sherman 2011-03-23 14:49:56 PDT
Created attachment 86690 [details]
Patch
Comment 3 Ilya Sherman 2011-03-23 14:51:56 PDT
Note: (At least for now) I'm developing on a Mac, and counting on the bots to detect any problems with the patch(es).
Comment 4 Build Bot 2011-03-23 15:14:34 PDT
Attachment 86690 [details] did not build on win:
Build output: http://queues.webkit.org/results/8235014
Comment 5 Ilya Sherman 2011-03-23 15:17:30 PDT
Created attachment 86704 [details]
Patch
Comment 6 Adam Roben (:aroben) 2011-03-24 06:10:40 PDT
Comment on attachment 86704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86704&action=review

The DRT changes look great.

> LayoutTests/ChangeLog:9
> +        * platform/chromium/fast/forms/input-autofilled-expected.txt: Removed.
> +        * platform/chromium/fast/forms/reset-autofilled-expected.txt: Removed.

Why can these be removed? AFAIK Chromium doesn't use the DumpRenderTree/win implementation.
Comment 7 Ilya Sherman 2011-03-24 18:26:35 PDT
(In reply to comment #6)
> > LayoutTests/ChangeLog:9
> > +        * platform/chromium/fast/forms/input-autofilled-expected.txt: Removed.
> > +        * platform/chromium/fast/forms/reset-autofilled-expected.txt: Removed.
> 
> Why can these be removed? AFAIK Chromium doesn't use the DumpRenderTree/win implementation.

Chromium Linux and Windows expectations inherit from non-Chromium expectations, so these were both originally added because the tests do pass on Chromium.  Since they now also pass on regular-style Windows, we can remove the overrides =)
Comment 8 WebKit Commit Bot 2011-03-24 22:06:45 PDT
Comment on attachment 86704 [details]
Patch

Clearing flags on attachment: 86704

Committed r81938: <http://trac.webkit.org/changeset/81938>
Comment 9 WebKit Commit Bot 2011-03-24 22:06:50 PDT
All reviewed patches have been landed.  Closing bug.