RESOLVED FIXED 56828
Implement layoutTestController.setAutoFilled in DRT on Windows 
https://bugs.webkit.org/show_bug.cgi?id=56828
Summary Implement layoutTestController.setAutoFilled in DRT on Windows
Adam Roben (:aroben)
Reported Tuesday, March 22, 2011 2:43:46 PM UTC
There are a few tests which rely on layoutTestController.setAutofilled. This function is unimplemented on Windows. We should implement it so we can run these tests!
Attachments
Patch (4.91 KB, patch)
2011-03-23 14:49 PDT, Ilya Sherman 		no flags
DetailsFormatted DiffDiff
Patch (4.92 KB, patch)
2011-03-23 15:17 PDT, Ilya Sherman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 Tuesday, March 22, 2011 3:54:38 PM UTC
<rdar://problem/9168468>
Ilya Sherman
Comment 2 Wednesday, March 23, 2011 10:49:56 PM UTC
Created attachment 86690 [details] Patch
Ilya Sherman
Comment 3 Wednesday, March 23, 2011 10:51:56 PM UTC
Note: (At least for now) I'm developing on a Mac, and counting on the bots to detect any problems with the patch(es).
Build Bot
Comment 4 Wednesday, March 23, 2011 11:14:34 PM UTC
Attachment 86690 [details] did not build on win: Build output: http://queues.webkit.org/results/8235014
Ilya Sherman
Comment 5 Wednesday, March 23, 2011 11:17:30 PM UTC
Created attachment 86704 [details] Patch
Adam Roben (:aroben)
Comment 6 Thursday, March 24, 2011 2:10:40 PM UTC
Comment on attachment 86704 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86704&action=review The DRT changes look great. > LayoutTests/ChangeLog:9 > + * platform/chromium/fast/forms/input-autofilled-expected.txt: Removed. > + * platform/chromium/fast/forms/reset-autofilled-expected.txt: Removed. Why can these be removed? AFAIK Chromium doesn't use the DumpRenderTree/win implementation.
Ilya Sherman
Comment 7 Friday, March 25, 2011 2:26:35 AM UTC
(In reply to comment #6) > > LayoutTests/ChangeLog:9 > > + * platform/chromium/fast/forms/input-autofilled-expected.txt: Removed. > > + * platform/chromium/fast/forms/reset-autofilled-expected.txt: Removed. > > Why can these be removed? AFAIK Chromium doesn't use the DumpRenderTree/win implementation. Chromium Linux and Windows expectations inherit from non-Chromium expectations, so these were both originally added because the tests do pass on Chromium. Since they now also pass on regular-style Windows, we can remove the overrides =)
WebKit Commit Bot
Comment 8 Friday, March 25, 2011 6:06:45 AM UTC
Comment on attachment 86704 [details] Patch Clearing flags on attachment: 86704 Committed r81938: <http://trac.webkit.org/changeset/81938>
WebKit Commit Bot
Comment 9 Friday, March 25, 2011 6:06:50 AM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.