Bug 56788 - GYP build should not have include paths that point within the source tree
Summary: GYP build should not have include paths that point within the source tree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 55018
  Show dependency treegraph
 
Reported: 2011-03-21 17:29 PDT by Adam Barth
Modified: 2011-03-21 22:40 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.67 KB, patch)
2011-03-21 18:01 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-03-21 17:29:59 PDT
Sayth Mark:

[[
The generated Xcode project explicitly adds header include paths that point within the source tree.
]]

I think I fixed this problem for the WebCore build, but I need to go back to the JavaScriptCore build and fix this issue.
Comment 1 Adam Barth 2011-03-21 18:01:35 PDT
Created attachment 86398 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-03-21 18:03:47 PDT
Comment on attachment 86398 [details]
Patch

What about for every non-mac port?  it seems removing these is premature.
Comment 3 Adam Barth 2011-03-21 18:15:28 PDT
> What about for every non-mac port?  it seems removing these is premature.

I'd say that adding them is premature.  :)

We'll solve the non-mac port problem when we get there.
Comment 4 Eric Seidel (no email) 2011-03-21 18:18:09 PDT
Comment on attachment 86398 [details]
Patch

I guess.  I'm pretty certain you'll want to revert this change the moment you try and build anywhere else, but your reasoning is fair.
Comment 5 WebKit Commit Bot 2011-03-21 22:40:08 PDT
Comment on attachment 86398 [details]
Patch

Clearing flags on attachment: 86398

Committed r81647: <http://trac.webkit.org/changeset/81647>
Comment 6 WebKit Commit Bot 2011-03-21 22:40:13 PDT
All reviewed patches have been landed.  Closing bug.