Bug 56786 - Production configuration in GYP isn't set up correctly
Summary: Production configuration in GYP isn't set up correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 55018
  Show dependency treegraph
 
Reported: 2011-03-21 17:27 PDT by Adam Barth
Modified: 2011-03-22 03:50 PDT (History)
4 users (show)

See Also:


Attachments
Patch (15.03 KB, patch)
2011-03-21 19:17 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (15.08 KB, patch)
2011-03-21 23:42 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-03-21 17:27:24 PDT
Sayth Mark:

[[
The generated JavaScriptCore.xcodeproj are not set up correctly (Production is no longer the default configuration, Production is based on DebugRelease.xcconfig rather than Base.xcconfig, etc.).
]]

It would be nice to know what else is in the "etc" part of the above list, but we should fix this problem before asking Mark to take another look.  I can also try to divine information from the existing project files.
Comment 1 Adam Barth 2011-03-21 19:17:50 PDT
Created attachment 86408 [details]
Patch
Comment 2 Adam Barth 2011-03-21 23:12:15 PDT
Comment on attachment 86408 [details]
Patch

This patch is wrong.  Please hold.
Comment 3 Adam Barth 2011-03-21 23:42:03 PDT
Created attachment 86428 [details]
Patch
Comment 4 Eric Seidel (no email) 2011-03-22 00:48:51 PDT
Comment on attachment 86428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86428&action=review

OK.

> Source/JavaScriptCore/ChangeLog:5
> +        Production configuration in GYP isn't set up correctly

Silly webkit-patch.
Comment 5 WebKit Commit Bot 2011-03-22 03:50:02 PDT
Comment on attachment 86428 [details]
Patch

Clearing flags on attachment: 86428

Committed r81655: <http://trac.webkit.org/changeset/81655>
Comment 6 WebKit Commit Bot 2011-03-22 03:50:09 PDT
All reviewed patches have been landed.  Closing bug.