Bug 56780 - Solve the Assertions.cpp / -Wno-missing-format-attribute mystery
Summary: Solve the Assertions.cpp / -Wno-missing-format-attribute mystery
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 55018
  Show dependency treegraph
 
Reported: 2011-03-21 16:38 PDT by Adam Barth
Modified: 2011-03-21 18:06 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.93 KB, patch)
2011-03-21 16:41 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (5.05 KB, patch)
2011-03-21 16:56 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-03-21 16:38:21 PDT
Solve the Assertions.cpp / -Wno-missing-format-attribute mystery
Comment 1 Adam Barth 2011-03-21 16:41:49 PDT
Created attachment 86386 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-03-21 16:50:47 PDT
Comment on attachment 86386 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86386&action=review

> Source/JavaScriptCore/wtf/Assertions.cpp:29
> +#pragma GCC diagnostic ignored "-Wmissing-format-attribute"

You should comment as to why this is needed for this file (so it has a prayer of being removed some day.
Comment 3 Adam Barth 2011-03-21 16:56:55 PDT
Created attachment 86388 [details]
Patch
Comment 4 Eric Seidel (no email) 2011-03-21 17:00:38 PDT
Comment on attachment 86388 [details]
Patch

Yay!
Comment 5 Adam Barth 2011-03-21 17:16:56 PDT
Comment on attachment 86388 [details]
Patch

Clearing flags on attachment: 86388

Committed r81624: <http://trac.webkit.org/changeset/81624>
Comment 6 Adam Barth 2011-03-21 17:17:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2011-03-21 18:06:22 PDT
http://trac.webkit.org/changeset/81624 might have broken Qt Linux Release
The following tests are not passing:
css2.1/t09-c5526c-display-00-e.html