Bug 56778 - Add WebCoreExportFileGenerator to WebCore GYP build
Summary: Add WebCoreExportFileGenerator to WebCore GYP build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 55018
  Show dependency tree / graph
 
Reported: 2011-03-21 16:15 PDT by Adam Barth
Modified: 2011-03-21 18:06 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.00 KB, patch)
2011-03-21 16:18 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (3.26 KB, patch)
2011-03-21 16:23 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-03-21 16:15:46 PDT 
Add WebCoreExportFileGenerator to WebCore GYP build
Comment 1 Adam Barth 2011-03-21 16:18:03 PDT 
Created attachment 86382 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-03-21 16:21:22 PDT 
Comment on attachment 86382 [details]
Patch

ok.
Comment 3 Adam Barth 2011-03-21 16:23:05 PDT 
Created attachment 86383 [details]
Patch
Comment 4 Adam Barth 2011-03-21 16:23:43 PDT 
Sorry, I was missing one dependency.
Comment 5 Eric Seidel (no email) 2011-03-21 16:45:02 PDT 
Comment on attachment 86383 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86383&action=review

> Source/WebCore/ChangeLog:8
> +        This target mirrors the eponymous target from WebCore.xcodeproj.

I think you mean anonymous?
Comment 6 Adam Barth 2011-03-21 16:49:08 PDT 
(In reply to comment #5)
> (From update of attachment 86383 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86383&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        This target mirrors the eponymous target from WebCore.xcodeproj.
> 
> I think you mean anonymous?

Turns out my usage is slightly incorrect unless you consider the targets to be the main characters and the build system to be a literary work:

http://www.thefreedictionary.com/eponymous
Comment 7 Adam Barth 2011-03-21 16:49:38 PDT 
Comment on attachment 86383 [details]
Patch

I think we can consider the build system a literary work.  :)
Comment 8 Eric Seidel (no email) 2011-03-21 17:02:26 PDT 
There are no people involved.  Thus no eponyms... I think.  Then again, I just learned the word "eponym".

http://www.thefreedictionary.com/eponym
Comment 9 Adam Barth 2011-03-21 17:14:36 PDT 
Comment on attachment 86383 [details]
Patch

Clearing flags on attachment: 86383

Committed r81623: <http://trac.webkit.org/changeset/81623>
Comment 10 Adam Barth 2011-03-21 17:14:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 WebKit Review Bot 2011-03-21 18:06:18 PDT 
http://trac.webkit.org/changeset/81623 might have broken Qt Linux Release
The following tests are not passing:
css2.1/t09-c5526c-display-00-e.html