Bug 56489 - Improve robustness of controls-without-preload by seeking to the start explicitly at the end of the test.
Summary: Improve robustness of controls-without-preload by seeking to the start explic...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 56473
  Show dependency treegraph
 
Reported: 2011-03-16 14:14 PDT by Dimitri Glazkov (Google)
Modified: 2011-03-17 09:11 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.90 KB, patch)
2011-03-16 14:14 PDT, Dimitri Glazkov (Google)
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-03-16 14:14:11 PDT
Improve robustness of controls-without-preload by seeking to the start explicitly at the end of the test.
Comment 1 Dimitri Glazkov (Google) 2011-03-16 14:14:56 PDT
Created attachment 85974 [details]
Patch
Comment 2 Eric Carlson 2011-03-16 14:28:39 PDT
Comment on attachment 85974 [details]
Patch

Nice change, thanks!
Comment 3 Dimitri Glazkov (Google) 2011-03-16 14:48:05 PDT
Committed r81280: <http://trac.webkit.org/changeset/81280>
Comment 4 Eric Carlson 2011-03-17 08:49:20 PDT
Odd, this caused a failure on the Leopard release bot: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r81306%20(29853)/media/controls-without-preload-pretty-diff.html

So Sam checked in new results: https://bugs.webkit.org/show_bug.cgi?id=56522
Comment 5 Dimitri Glazkov (Google) 2011-03-17 08:53:34 PDT
(In reply to comment #4)
> Odd, this caused a failure on the Leopard release bot: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r81306%20(29853)/media/controls-without-preload-pretty-diff.html
> 
> So Sam checked in new results: https://bugs.webkit.org/show_bug.cgi?id=56522

Nah. The test was failing like that for a long time. I thought I broke it too, but I looked back and could see this failing as far as r80697: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r80697%20%2829439%29/media/controls-without-preload-pretty-diff.html
Comment 6 Dimitri Glazkov (Google) 2011-03-17 08:54:49 PDT
And here's Sam's conclusion: https://bugs.webkit.org/show_bug.cgi?id=56532
Comment 7 Eric Carlson 2011-03-17 09:03:59 PDT
Indeed, the problem is that the fullscreen button isn't showing (it is 16x16, the mute button is 14x12):

-  RenderButton {INPUT} at (297,4) size 16x16
-  RenderButton {INPUT} at (267,6) size 14x12
+ RenderButton {INPUT} at (297,6) size 14x12

but Sam's conclusion in https://bugs.webkit.org/show_bug.cgi?id=56532 is for WebKit2.

In any case, the failure didn't start with this change.
Comment 8 Dimitri Glazkov (Google) 2011-03-17 09:11:50 PDT
(In reply to comment #7)
> Indeed, the problem is that the fullscreen button isn't showing (it is 16x16, the mute button is 14x12):
> 
> -  RenderButton {INPUT} at (297,4) size 16x16
> -  RenderButton {INPUT} at (267,6) size 14x12
> + RenderButton {INPUT} at (297,6) size 14x12
> 
> but Sam's conclusion in https://bugs.webkit.org/show_bug.cgi?id=56532 is for WebKit2.
> 
> In any case, the failure didn't start with this change.

So the MediaPlayerPrivate::supportsFullscreen must be returning false for Leopard on this bot? That seems to be the only code path that could diverge.