Bug 56473 - Add play state callbacks to MediaControls, kill timeUpdate timer.
Summary: Add play state callbacks to MediaControls, kill timeUpdate timer.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on: 56489
Blocks: 53020
  Show dependency treegraph
 
Reported: 2011-03-16 11:16 PDT by Dimitri Glazkov (Google)
Modified: 2011-03-16 15:16 PDT (History)
2 users (show)

See Also:


Attachments
Patch (6.19 KB, patch)
2011-03-16 11:18 PDT, Dimitri Glazkov (Google)
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-03-16 11:16:25 PDT
Add play state callbacks to MediaControls, kill timeUpdate timer.
Comment 1 Dimitri Glazkov (Google) 2011-03-16 11:18:51 PDT
Created attachment 85944 [details]
Patch
Comment 2 Eric Carlson 2011-03-16 11:22:35 PDT
Comment on attachment 85944 [details]
Patch

Nice!
Comment 3 Dimitri Glazkov (Google) 2011-03-16 11:56:06 PDT
(In reply to comment #2)
> (From update of attachment 85944 [details])
> Nice!

Since this change does an extra update of the timeline/status as soon as we start playing, the status values are more accurate. However, this affects results in media/controls-without-preload.html, because canplaythrough event is fired asynchronously. By the time it's fired, we already started playing and the status is slightly different.

Should I:
a) change expectations for the test
b) remove updating on start?
Comment 4 Dimitri Glazkov (Google) 2011-03-16 14:52:21 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 85944 [details] [details])
> > Nice!
> 
> Since this change does an extra update of the timeline/status as soon as we start playing, the status values are more accurate. However, this affects results in media/controls-without-preload.html, because canplaythrough event is fired asynchronously. By the time it's fired, we already started playing and the status is slightly different.
> 
> Should I:
> a) change expectations for the test
> b) remove updating on start?

I ended up improving the test in http://trac.webkit.org/changeset/81280.
Comment 5 Dimitri Glazkov (Google) 2011-03-16 15:16:01 PDT
Committed r81283: <http://trac.webkit.org/changeset/81283>