Bug 56430 - WebCore GYP build should build platform/
Summary: WebCore GYP build should build platform/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 55018
  Show dependency treegraph
 
Reported: 2011-03-15 17:09 PDT by Adam Barth
Modified: 2011-03-16 01:58 PDT (History)
3 users (show)

See Also:


Attachments
Patch (13.68 KB, patch)
2011-03-15 17:11 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (11.98 KB, patch)
2011-03-15 23:18 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-03-15 17:09:18 PDT
WebCore GYP build should build platform/
Comment 1 Adam Barth 2011-03-15 17:11:13 PDT
Created attachment 85880 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-03-15 17:42:10 PDT
Comment on attachment 85880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85880&action=review

> Source/WebCore/dom/ContainerNode.cpp:168
>          notifyChildInserted(child);
> +        if (!child->inDocument())
> +            break;

Um... wrong change?
Comment 3 Adam Barth 2011-03-15 22:42:00 PDT
Comment on attachment 85880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85880&action=review

>> Source/WebCore/dom/ContainerNode.cpp:168
>> +        if (!child->inDocument())
>> +            break;
> 
> Um... wrong change?

Oops!  Indeed.
Comment 4 Adam Barth 2011-03-15 23:18:04 PDT
Created attachment 85912 [details]
Patch
Comment 5 WebKit Commit Bot 2011-03-16 01:58:47 PDT
Comment on attachment 85912 [details]
Patch

Clearing flags on attachment: 85912

Committed r81230: <http://trac.webkit.org/changeset/81230>
Comment 6 WebKit Commit Bot 2011-03-16 01:58:52 PDT
All reviewed patches have been landed.  Closing bug.