RESOLVED FIXED Bug 56351
Add remaining files to WebCore.gypi 
https://bugs.webkit.org/show_bug.cgi?id=56351
Summary Add remaining files to WebCore.gypi
Adam Barth
Reported 2011-03-14 18:19:17 PDT
Add remaining files to WebCore.gypi
Attachments
Patch (77.97 KB, patch)
2011-03-14 18:22 PDT, Adam Barth 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-03-14 18:22:12 PDT
Created attachment 85751 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2011-03-14 18:26:33 PDT
Comment on attachment 85751 [details] Patch my rubberstamp is shiny.
Adam Barth
Comment 3 2011-03-14 18:27:37 PDT
Thanks. I'm going to let the EWS bots chew on this for a bit. It builds locally, but that's only half the battle.
Adam Barth
Comment 4 2011-03-14 18:40:03 PDT
OMG, it builds on the Lunix.
Adam Barth
Comment 5 2011-03-14 18:43:37 PDT
http://trac.webkit.org/changeset/81093
WebKit Review Bot
Comment 6 2011-03-14 19:13:12 PDT
http://trac.webkit.org/changeset/81093 might have broken Chromium Win Release
Adam Barth
Comment 7 2011-03-14 19:14:13 PDT
Attempted fix in http://trac.webkit.org/changeset/81096
Alexander Pavlov (apavlov)
Comment 8 2011-03-15 07:32:14 PDT
This change breaks the Chromium compilability on the Linux (dbg-shlib) builder, so I'm rolling it out for now. The relevant log fragment: SOLINK(target) out/Debug/obj.target/third_party/WebKit/Source/WebCore/WebCore.gyp/libwebcore_svg.so /usr/bin/ld: error: out/Debug/obj.target/webcore_platform/third_party/WebKit/Source/WebCore/platform/text/LocalizedNumberNone.o: multiple definition of 'WebCore::parseLocalizedNumber(WTF::String const&)' /usr/bin/ld: out/Debug/obj.target/webcore_platform/third_party/WebKit/Source/WebCore/platform/text/LocalizedNumberICU.o: previous definition here /usr/bin/ld: error: out/Debug/obj.target/webcore_platform/third_party/WebKit/Source/WebCore/platform/text/LocalizedNumberNone.o: multiple definition of 'WebCore::formatLocalizedNumber(double)' /usr/bin/ld: out/Debug/obj.target/webcore_platform/third_party/WebKit/Source/WebCore/platform/text/LocalizedNumberICU.o: previous definition here /usr/bin/ld: error: out/Debug/obj.target/webcore_platform/third_party/WebKit/Source/WebCore/platform/text/TextEncodingDetectorNone.o: multiple definition of 'WebCore::detectTextEncoding(char const*, unsigned int, char const*, WebCore::TextEncoding*)' /usr/bin/ld: out/Debug/obj.target/webcore_platform/third_party/WebKit/Source/WebCore/platform/text/TextEncodingDetectorICU.o: previous definition here collect2: ld returned 1 exit status make: *** [out/Debug/obj.target/third_party/WebKit/Source/WebCore/WebCore.gyp/libwebcore_platform.so] Error 1
Alexander Pavlov (apavlov)
Comment 9 2011-03-15 08:33:38 PDT
Courtesy of loislo@chromium.org, the fix was landed as http://trac.webkit.org/changeset/81134
Adam Barth
Comment 10 2011-03-15 10:55:56 PDT
(In reply to comment #9) > Courtesy of loislo@chromium.org, the fix was landed as http://trac.webkit.org/changeset/81134 Thanks for the fix! Sorry I don't have a good way to test the dbg-shlib build. :(
Note You need to log in before you can comment on or make changes to this bug.