Add remaining files to WebCore.gypi
Created attachment 85751 [details] Patch
Comment on attachment 85751 [details] Patch my rubberstamp is shiny.
Thanks. I'm going to let the EWS bots chew on this for a bit. It builds locally, but that's only half the battle.
OMG, it builds on the Lunix.
http://trac.webkit.org/changeset/81093
http://trac.webkit.org/changeset/81093 might have broken Chromium Win Release
Attempted fix in http://trac.webkit.org/changeset/81096
This change breaks the Chromium compilability on the Linux (dbg-shlib) builder, so I'm rolling it out for now. The relevant log fragment: SOLINK(target) out/Debug/obj.target/third_party/WebKit/Source/WebCore/WebCore.gyp/libwebcore_svg.so /usr/bin/ld: error: out/Debug/obj.target/webcore_platform/third_party/WebKit/Source/WebCore/platform/text/LocalizedNumberNone.o: multiple definition of 'WebCore::parseLocalizedNumber(WTF::String const&)' /usr/bin/ld: out/Debug/obj.target/webcore_platform/third_party/WebKit/Source/WebCore/platform/text/LocalizedNumberICU.o: previous definition here /usr/bin/ld: error: out/Debug/obj.target/webcore_platform/third_party/WebKit/Source/WebCore/platform/text/LocalizedNumberNone.o: multiple definition of 'WebCore::formatLocalizedNumber(double)' /usr/bin/ld: out/Debug/obj.target/webcore_platform/third_party/WebKit/Source/WebCore/platform/text/LocalizedNumberICU.o: previous definition here /usr/bin/ld: error: out/Debug/obj.target/webcore_platform/third_party/WebKit/Source/WebCore/platform/text/TextEncodingDetectorNone.o: multiple definition of 'WebCore::detectTextEncoding(char const*, unsigned int, char const*, WebCore::TextEncoding*)' /usr/bin/ld: out/Debug/obj.target/webcore_platform/third_party/WebKit/Source/WebCore/platform/text/TextEncodingDetectorICU.o: previous definition here collect2: ld returned 1 exit status make: *** [out/Debug/obj.target/third_party/WebKit/Source/WebCore/WebCore.gyp/libwebcore_platform.so] Error 1
Courtesy of loislo@chromium.org, the fix was landed as http://trac.webkit.org/changeset/81134
(In reply to comment #9) > Courtesy of loislo@chromium.org, the fix was landed as http://trac.webkit.org/changeset/81134 Thanks for the fix! Sorry I don't have a good way to test the dbg-shlib build. :(