RESOLVED FIXED 56337
Enable -Werror on ANGLE
https://bugs.webkit.org/show_bug.cgi?id=56337
Summary Enable -Werror on ANGLE
David Kilzer (:ddkilzer)
Reported 2011-03-14 14:38:18 PDT
We should enable -Werror on ANGLE to catch compiler issues. There are a few fixes for clang that must be addressed first.
Attachments
Patch 5/5: Enable -Werror on ANGLE (1.75 KB, patch)
2011-03-14 16:09 PDT, David Kilzer (:ddkilzer)
abarth: review+
Patch 1/5: Fix clang warning: ConstantUnion.h:56:17: warning: 7 enumeration values not handled in switch (2.95 KB, patch)
2011-03-14 16:09 PDT, David Kilzer (:ddkilzer)
no flags
Patch 2/5: Fix clang warning: ParseHelper.cpp:264:13: warning: 8 enumeration values not handled in switch (2.62 KB, patch)
2011-03-14 16:10 PDT, David Kilzer (:ddkilzer)
no flags
Patch 3/5: Fix clang warnings: Intermediate.cpp: warning: '&&' within '||' (8.27 KB, patch)
2011-03-14 16:10 PDT, David Kilzer (:ddkilzer)
no flags
Patch 4/5: Fix clang warnings in PoolAlloc.cpp (4.65 KB, patch)
2011-03-14 16:11 PDT, David Kilzer (:ddkilzer)
no flags
David Kilzer (:ddkilzer)
Comment 1 2011-03-14 16:09:04 PDT
Created attachment 85736 [details] Patch 5/5: Enable -Werror on ANGLE Posting the last one first to make sure gcc-4.2/llvm-gcc-4.2 still builds with this change.
David Kilzer (:ddkilzer)
Comment 2 2011-03-14 16:09:44 PDT
Created attachment 85737 [details] Patch 1/5: Fix clang warning: ConstantUnion.h:56:17: warning: 7 enumeration values not handled in switch
David Kilzer (:ddkilzer)
Comment 3 2011-03-14 16:10:15 PDT
Created attachment 85738 [details] Patch 2/5: Fix clang warning: ParseHelper.cpp:264:13: warning: 8 enumeration values not handled in switch
David Kilzer (:ddkilzer)
Comment 4 2011-03-14 16:10:44 PDT
Created attachment 85739 [details] Patch 3/5: Fix clang warnings: Intermediate.cpp: warning: '&&' within '||'
David Kilzer (:ddkilzer)
Comment 5 2011-03-14 16:11:14 PDT
Created attachment 85740 [details] Patch 4/5: Fix clang warnings in PoolAlloc.cpp
WebKit Review Bot
Comment 6 2011-03-14 16:14:50 PDT
Attachment 85739 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ANGLE/ChangeLog', u'Sour..." exit_code: 1 Source/ThirdParty/ANGLE/src/compiler/Intermediate.cpp:1008: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/ThirdParty/ANGLE/src/compiler/Intermediate.cpp:1020: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zhenyao Mo
Comment 7 2011-03-14 16:30:55 PDT
This should be fixed upstream ANGLE. If you commit it here, after a ANGLE roll in the future, your change will be lost. I see you already filed a bug to ANGLE. Could you upload your patch there? Once it's reviewed and landed upstream, we can do another ANGLE roll in webkit.
David Kilzer (:ddkilzer)
Comment 8 2011-03-14 20:15:42 PDT
(In reply to comment #7) > This should be fixed upstream ANGLE. If you commit it here, after a ANGLE roll in the future, your change will be lost. > > I see you already filed a bug to ANGLE. Could you upload your patch there? Once it's reviewed and landed upstream, we can do another ANGLE roll in webkit. So you don't merge changes from ANGLE into WebKit--you just land new code and delete whatever local changes were made?
David Kilzer (:ddkilzer)
Comment 9 2011-03-14 20:19:47 PDT
(In reply to comment #7) > I see you already filed a bug to ANGLE. Could you upload your patch there? Once it's reviewed and landed upstream, we can do another ANGLE roll in webkit. I'll upload the patches upstream as well.
David Kilzer (:ddkilzer)
Comment 10 2011-03-14 20:24:23 PDT
Comment on attachment 85737 [details] Patch 1/5: Fix clang warning: ConstantUnion.h:56:17: warning: 7 enumeration values not handled in switch Upstream bug: <http://code.google.com/p/angleproject/issues/detail?id=124>
David Kilzer (:ddkilzer)
Comment 11 2011-03-14 20:24:38 PDT
Comment on attachment 85738 [details] Patch 2/5: Fix clang warning: ParseHelper.cpp:264:13: warning: 8 enumeration values not handled in switch Upstream bug: <http://code.google.com/p/angleproject/issues/detail?id=125>
David Kilzer (:ddkilzer)
Comment 12 2011-03-14 20:24:53 PDT
Comment on attachment 85739 [details] Patch 3/5: Fix clang warnings: Intermediate.cpp: warning: '&&' within '||' Upstream bug: <http://code.google.com/p/angleproject/issues/detail?id=126>
David Kilzer (:ddkilzer)
Comment 13 2011-03-14 20:25:06 PDT
Comment on attachment 85740 [details] Patch 4/5: Fix clang warnings in PoolAlloc.cpp Upstream bug: <http://code.google.com/p/angleproject/issues/detail?id=127>
David Kilzer (:ddkilzer)
Comment 14 2011-03-14 20:26:37 PDT
Patch 5/5 (Attachment 85736 [details]) is now blocked on the upstream patches landing, then ANGLE being updated.
WebKit Review Bot
Comment 15 2011-03-14 21:46:56 PDT
Adam Barth
Comment 16 2011-03-15 02:00:24 PDT
Comment on attachment 85736 [details] Patch 5/5: Enable -Werror on ANGLE I support this product and or service (assuming it builds).
Zhenyao Mo
Comment 17 2011-03-15 09:18:59 PDT
(In reply to comment #8) > (In reply to comment #7) > > This should be fixed upstream ANGLE. If you commit it here, after a ANGLE roll in the future, your change will be lost. > > > > I see you already filed a bug to ANGLE. Could you upload your patch there? Once it's reviewed and landed upstream, we can do another ANGLE roll in webkit. > > So you don't merge changes from ANGLE into WebKit--you just land new code and delete whatever local changes were made? Yes. That's at least what we've done so far.
David Kilzer (:ddkilzer)
Comment 18 2011-03-15 11:59:18 PDT
(In reply to comment #14) > Patch 5/5 (Attachment 85736 [details]) is now blocked on the upstream patches landing, then ANGLE being updated. Filed Bug 56396 to update ANGLE to at least r575, which will pick up the necessary fixes to enable -Werror.
David Kilzer (:ddkilzer)
Comment 19 2011-05-04 11:13:45 PDT
David Kilzer (:ddkilzer)
Comment 20 2011-05-04 11:14:31 PDT
Note You need to log in before you can comment on or make changes to this bug.