Bug 56231 - Introduce project_dir variable and make paths a whole lot saner. Ok, a little bit saner.
Summary: Introduce project_dir variable and make paths a whole lot saner. Ok, a little...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 55018
  Show dependency treegraph
 
Reported: 2011-03-11 15:50 PST by Dimitri Glazkov (Google)
Modified: 2011-03-11 18:53 PST (History)
2 users (show)

See Also:


Attachments
Patch (5.82 KB, patch)
2011-03-11 15:51 PST, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-03-11 15:50:34 PST
Introduce project_dir variable and make paths a whole lot saner. Ok, a little bit saner.
Comment 1 Dimitri Glazkov (Google) 2011-03-11 15:51:45 PST
Created attachment 85549 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-03-11 16:33:28 PST
Comment on attachment 85549 [details]
Patch

Nice.  Feel free to CC me on any other gyp changes.
Comment 3 WebKit Commit Bot 2011-03-11 17:06:00 PST
Comment on attachment 85549 [details]
Patch

Clearing flags on attachment: 85549

Committed r80906: <http://trac.webkit.org/changeset/80906>
Comment 4 WebKit Commit Bot 2011-03-11 17:06:05 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Adam Barth 2011-03-11 18:53:16 PST
Comment on attachment 85549 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85549&action=review

> Source/JavaScriptCore/JavaScriptCore.gypi:3
> +        'project_dir': [ '<(DEPTH)/JavaScriptCore' ],

You don't need to use DEPTH here.  project_dir ends in _dir, which means it's treated as relative to the file its in.  So...  "." would have worked too.