Bug 56217 - Start using derived sources correctly and link minidom with JavaScriptCore gyp project.
Summary: Start using derived sources correctly and link minidom with JavaScriptCore gy...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 55018
  Show dependency tree / graph
 
Reported: 2011-03-11 13:08 PST by Dimitri Glazkov (Google)
Modified: 2011-03-11 13:59 PST (History)
1 user (show)

See Also:

Attachments
Patch (4.51 KB, patch)
2011-03-11 13:10 PST, Dimitri Glazkov (Google) 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-03-11 13:08:51 PST 
Start using derived sources correctly and link minidom with JavaScriptCore gyp project.
Comment 1 Dimitri Glazkov (Google) 2011-03-11 13:10:22 PST 
Created attachment 85517 [details]
Patch
Comment 2 Adam Barth 2011-03-11 13:28:05 PST 
Comment on attachment 85517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85517&action=review

This restructures how the build works a bit, but probably in a good direction.

> Source/JavaScriptCore/gyp/generate-dtrace-header.sh:3
> +TRACING_D="${SRCROOT}/../runtime/Tracing.d";

The ... here makes me a bit sad, but it's probably ok.  Having these paths based on DEPTH is better.  Maybe we should pass the directory in like we're doing for the intermediate dir.
Comment 3 Dimitri Glazkov (Google) 2011-03-11 13:59:54 PST 
Committed r80882: <http://trac.webkit.org/changeset/80882>