Bug 56210 – WebKit2: Implement a full screen window controller

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Jer Noble]

WebKit2 needs a full screen window controller, like WebKit/WebFullScreenController.

[Jer Noble]

Created attachment 85515 [details]
Patch

[Jer Noble]

Note this patch contains changes to WebFullScreenController.{h,cpp}.  (Copyright year changes only.)  This is because of the dumb way git does rename detection.

[Jer Noble]

Created attachment 85518 [details]
Patch

Updated the ChangeLog with more information.

[Anders Carlsson]

Comment on attachment 85518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85518&action=review

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:361
> +- (void)getFullScreenRect:(WebCore::IntRect*)rect

This can just return an IntRect object.

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:368
> +    rect->setX(roundl(NSMinX(windowFrame)));
> +    rect->setY(roundl(NSMinY(windowFrame)));
> +    rect->setWidth(roundl(NSWidth(windowFrame)));
> +    rect->setHeight(roundl(NSHeight(windowFrame)));

Instead of doing this, you can just use enclosingIntRect([[self window] frame]);

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:477
> +        return NULL;

This should be return 0;

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:507
> +    return (WKFullScreenWindow *)[self window];

Please add a

ASSERT([[self window] isKindOfClass:[WKFullScreenWindow class]])

before casting.

[Jer Noble]

Comment on attachment 85518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85518&action=review

>> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:361
>> +- (void)getFullScreenRect:(WebCore::IntRect*)rect
> 
> This can just return an IntRect object.

Great idea. :)

>> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:368
>> +    rect->setHeight(roundl(NSHeight(windowFrame)));
> 
> Instead of doing this, you can just use enclosingIntRect([[self window] frame]);

You learn something every day.  Used.

>> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:477
>> +        return NULL;
> 
> This should be return 0;

Right.  I got my C and C++ style guide rules backwards.  Changed.

>> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:507
>> +    return (WKFullScreenWindow *)[self window];
> 
> Please add a
> 
> ASSERT([[self window] isKindOfClass:[WKFullScreenWindow class]])
> 
> before casting.

Added.  Thanks!

[Jer Noble]

Committed r80923: <http://trac.webkit.org/changeset/80923>