Bug 55993 - WebKit2: Plumb new full screen animation APIs through WebKit2.
Summary: WebKit2: Plumb new full screen animation APIs through WebKit2.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks: 56210 56220 56226
  Show dependency tree / graph
 
Reported: 2011-03-08 21:37 PST by Jer Noble
Modified: 2011-03-11 21:38 PST (History)
4 users (show)

See Also:

Attachments
Patch (19.07 KB, patch)
2011-03-08 22:54 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (19.30 KB, patch)
2011-03-09 01:12 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (19.30 KB, patch)
2011-03-11 10:42 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (19.02 KB, patch)
2011-03-11 11:45 PST, Jer Noble 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2011-03-08 21:37:46 PST 
The new Document animation APIs need to be plumbed through WebKit2 from the WebProcess to the UIProcess (and vice versa).
Comment 1 Jer Noble 2011-03-08 22:54:51 PST 
Created attachment 85134 [details]
Patch
Comment 2 Jer Noble 2011-03-09 01:12:11 PST 
Created attachment 85143 [details]
Patch
Comment 3 WebKit Review Bot 2011-03-09 01:53:48 PST 
Attachment 85134 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8117256
Comment 4 WebKit Review Bot 2011-03-09 03:43:20 PST 
Attachment 85143 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8118288
Comment 5 Jer Noble 2011-03-09 08:29:16 PST 
It looks like the mac builder didn't pick up the changes in 55992.
Comment 6 Jer Noble 2011-03-11 09:48:56 PST 
Since Bug #55992 was marked WONTFIX, updating this patch with stubbed out API.
Comment 7 Jer Noble 2011-03-11 10:42:37 PST 
Created attachment 85491 [details]
Patch
Comment 8 Jer Noble 2011-03-11 11:45:45 PST 
Created attachment 85504 [details]
Patch

Somehow, two braces became transposed.  This patch builds cleanly on amac.
Comment 9 Anders Carlsson 2011-03-11 16:55:48 PST 
Comment on attachment 85504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85504&action=review

> Source/WebKit2/WebProcess/FullScreen/WebFullScreenManager.cpp:69
> +    m_page->sendSync(Messages::WebFullScreenManagerProxy::SupportsFullScreen(), supports, 0, CoreIPC::Connection::NoTimeout);

No need to pass NoTimeout to sendSync, that's the default argument.
Comment 10 Jer Noble 2011-03-11 17:09:19 PST 
Comment on attachment 85504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85504&action=review

>> Source/WebKit2/WebProcess/FullScreen/WebFullScreenManager.cpp:69
>> +    m_page->sendSync(Messages::WebFullScreenManagerProxy::SupportsFullScreen(), supports, 0, CoreIPC::Connection::NoTimeout);
> 
> No need to pass NoTimeout to sendSync, that's the default argument.

Indeed, deleted.  (I think, in addition, that 0 is unnecessary.  We want m_page to put its own pageID for that value.)
Comment 11 Jer Noble 2011-03-11 21:38:28 PST 
Committed r80922: <http://trac.webkit.org/changeset/80922>