Bug 56207 - Tweak dylib paths and add dtrace header generation action to JavaScriptCore gyp project.
Summary: Tweak dylib paths and add dtrace header generation action to JavaScriptCore g...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 55018
  Show dependency tree / graph
 
Reported: 2011-03-11 11:05 PST by Dimitri Glazkov (Google)
Modified: 2011-03-11 11:13 PST (History)
1 user (show)

See Also:

Attachments
Patch (3.79 KB, patch)
2011-03-11 11:08 PST, Dimitri Glazkov (Google) 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-03-11 11:05:54 PST 
Tweak dylib paths and add dtrace header generation action to JavaScriptCore gyp project.
Comment 1 Dimitri Glazkov (Google) 2011-03-11 11:08:18 PST 
Created attachment 85497 [details]
Patch
Comment 2 Adam Barth 2011-03-11 11:09:33 PST 
Comment on attachment 85497 [details]
Patch

Thanks.
Comment 3 Dimitri Glazkov (Google) 2011-03-11 11:11:52 PST 
Committed r80865: <http://trac.webkit.org/changeset/80865>
Comment 4 Eric Seidel (no email) 2011-03-11 11:13:16 PST 
Comment on attachment 85497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85497&action=review

> Source/JavaScriptCore/gyp/JavaScriptCore.gyp:149
> +          'action_name': 'Generate DTrace Header',
> +          'inputs': [],
> +           'outputs': [],
> +           'action': [

funny indent.
Comment 5 Eric Seidel (no email) 2011-03-11 11:13:41 PST 
Comment on attachment 85497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85497&action=review

> Source/JavaScriptCore/gyp/generate-dtrace-header.sh:4
> +TRACING_D="${SRCROOT}/runtime/Tracing.d";
> +TRACING_H="${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/TracingDtrace.h";

the ; are not needed.

> Source/JavaScriptCore/gyp/generate-dtrace-header.sh:8
> +fi;

I don't think the ; i sneeded.