Bug 56030 – Leaks Viewer: Would like to be able to look at all leaks files from a particular build at once, rather than one at a time

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adam Roben (:aroben)]

The Leaks Viewer can currently only look at one leak file at a time. But it would be very useful to be able to look at the combined view of all leaks files from a particular build at once.

[Adam Roben (:aroben)]

I have a patch for this that seems to be working. It would be nice if we displayed how many leaks files we have left to load, though. And for some reason Leaks Viewer only reports 10341 leaks for <http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/15471>, even though run-webkit-tests says there are 10342.

[Adam Roben (:aroben)]

Created attachment 85486 [details]
Make it possible to view all leaks from a build at once in Leaks Viewer

[David Kilzer (:ddkilzer)]

Comment on attachment 85486 [details]
Make it possible to view all leaks from a build at once in Leaks Viewer

View in context: https://bugs.webkit.org/attachment.cgi?id=85486&action=review

r=me

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:58
> +    <script src=LeaksLoader.js></script>
> +    <script src=LeaksParser.js></script>
>      <script src=LeaksViewer.js></script>
> +    <script src=Utilities.js></script>

Nit: You should really use double-quotes around the value of the src attributes.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:65
> +            <span id=loading-indicator-label>Loading&hellip;</span>

Nit: And around the id attribute.

[Adam Roben (:aroben)]

Comment on attachment 85486 [details]
Make it possible to view all leaks from a build at once in Leaks Viewer

View in context: https://bugs.webkit.org/attachment.cgi?id=85486&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:58
>> +    <script src=Utilities.js></script>
> 
> Nit: You should really use double-quotes around the value of the src attributes.

Is that a stylistic preference? Or is there a practical problem?

[David Kilzer (:ddkilzer)]

(In reply to comment #4)
> (From update of attachment 85486 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85486&action=review
> 
> >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:58
> >> +    <script src=Utilities.js></script>
> > 
> > Nit: You should really use double-quotes around the value of the src attributes.
> 
> Is that a stylistic preference? Or is there a practical problem?

I thought it was a best practice.  Looks strange to me without quotes.  Does HTML5 not "require" this?

[Adam Roben (:aroben)]

(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 85486 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=85486&action=review
> > 
> > >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:58
> > >> +    <script src=Utilities.js></script>
> > > 
> > > Nit: You should really use double-quotes around the value of the src attributes.
> > 
> > Is that a stylistic preference? Or is there a practical problem?
> 
> I thought it was a best practice.  Looks strange to me without quotes.  Does HTML5 not "require" this?

It does not require it. (You can test on validator.nu.)

[Adam Roben (:aroben)]

Committed r80864: <http://trac.webkit.org/changeset/80864>

[Simon Fraser (smfr)]

I tried this and it failed with "TypeError: Cannot post cyclic structures."

[Adam Roben (:aroben)]

(In reply to comment #8)
> I tried this and it failed with "TypeError: Cannot post cyclic structures."

That is bug 56090. (Leaks Viewer still doesn't work with Safari 5, it turns out.)