Bug 56090 - Leaks Viewer throws "Cannot post cyclic structures" in Safari 5
Summary: Leaks Viewer throws "Cannot post cyclic structures" in Safari 5
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Sam Weinig
URL: http://build.webkit.org/LeaksViewer/?...
Keywords:
Depends on:
Blocks: 56035
  Show dependency tree / graph
 
Reported: 2011-03-10 04:14 PST by Adam Roben (:aroben)
Modified: 2011-04-25 16:42 PDT (History)
1 user (show)

See Also:

Attachments
Patch (14.62 KB, patch)
2011-04-25 16:37 PDT, Sam Weinig 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-03-10 04:14:10 PST 
To reproduce:

1. Go to http://build.webkit.org/LeaksViewer/?url=http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80699%20(15461)/DumpRenderTree-leaks.txt

The leaks output never shows up. The Inspector shows that a "TypeError: Cannot post cyclic structures" exception was thrown.
Comment 1 Adam Roben (:aroben) 2011-03-10 04:15:43 PST 
In addition, Leaks Viewer says it's "loading" forever. That's bug 56091.
Comment 2 Adam Roben (:aroben) 2011-03-10 06:06:41 PST 
Oh, the error doesn't happen in ToT, only in Safari 5.
Comment 3 Adam Roben (:aroben) 2011-03-10 08:15:49 PST 
I'm surprised this doesn't happen for all leaks files.
Comment 4 Adam Roben (:aroben) 2011-03-10 08:19:46 PST 
Maybe we just shouldn't use Web Workers in Safari 5.
Comment 5 Adam Roben (:aroben) 2011-03-10 08:22:20 PST 
I think the only way to test whether cyclic structures can be sent in postMessage is to try doing it and see if an exception is thrown.
Comment 6 Adam Roben (:aroben) 2011-03-10 08:35:54 PST 
â€ĶI guess it does happen on any leaks file.
Comment 7 Sam Weinig 2011-04-25 16:37:09 PDT 
Created attachment 91012 [details]
Patch
Comment 8 Sam Weinig 2011-04-25 16:42:08 PDT 
Committed r84840: <http://trac.webkit.org/changeset/84840>