Bug 55947 - The first time animations are committed they have a bad start time
Summary: The first time animations are committed they have a bad start time
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Chris Marrin
URL:
Keywords:
Depends on:
Blocks: 52468
  Show dependency treegraph
 
Reported: 2011-03-08 09:53 PST by Chris Marrin
Modified: 2011-03-08 10:30 PST (History)
0 users

See Also:


Attachments
Patch (1.57 KB, patch)
2011-03-08 10:04 PST, Chris Marrin
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2011-03-08 09:53:13 PST
The animationStarted time fed to the animation controller from CACFLayerTreeHost is derived from WKCACFViewGetLastCommitTime, corrected for the difference between media time (which CACF uses) and system time (which WebKit uses). But the first time a render is performed WKCACFViewGetLastCommitTime is zero. We should check for this case and correct it so webkit doesn't think animations started in the distant past.
Comment 1 Chris Marrin 2011-03-08 10:04:10 PST
Created attachment 85056 [details]
Patch
Comment 2 Chris Marrin 2011-03-08 10:30:14 PST
Landed in http://trac.webkit.org/changeset/80570