Bug 52468 - REGRESSION (5.0.3-ToT): Scrolling text doesn't scroll in Star Wars intro animation
Summary: REGRESSION (5.0.3-ToT): Scrolling text doesn't scroll in Star Wars intro anim...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Chris Marrin
URL: http://www.gesteves.com/experiments/s...
Keywords: InRadar, PlatformOnly, Regression
: 53494 (view as bug list)
Depends on: 55947
Blocks:
  Show dependency tree / graph
 
Reported: 2011-01-14 12:20 PST by Adam Roben (:aroben)
Modified: 2011-03-11 11:19 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.27 KB, patch)
2011-03-09 13:59 PST, Chris Marrin 		no flags Details | Formatted Diff | Diff
Patch (2.21 KB, patch)
2011-03-11 10:38 PST, Chris Marrin 		aroben: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-01-14 12:20:26 PST 
To reproduce:

1. Go to http://www.gesteves.com/experiments/starwars.html

After the "Star Wars" text fades into the distance, the scrolling text appears. But it appears all at once, and doesn't scroll at all. This worked just great in 5.0.3.
Comment 1 Adam Roben (:aroben) 2011-01-14 12:20:49 PST 
The text also seems to be scaled down too small.
Comment 2 Adam Roben (:aroben) 2011-01-14 12:22:03 PST 
<rdar://problem/8866929>
Comment 3 Chris Marrin 2011-03-09 12:37:50 PST 
*** Bug 53494 has been marked as a duplicate of this bug. ***
Comment 4 Chris Marrin 2011-03-09 13:59:37 PST 
Created attachment 85227 [details]
Patch
Comment 5 Simon Fraser (smfr) 2011-03-09 14:04:38 PST 
Comment on attachment 85227 [details]
Patch

We need this #ifdef because of behavior changes between SnowLeopard and later, so you can't just remove it.
Comment 6 Chris Marrin 2011-03-11 10:38:13 PST 
Created attachment 85490 [details]
Patch
Comment 7 Adam Roben (:aroben) 2011-03-11 10:42:53 PST 
Comment on attachment 85490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85490&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1604
> +#if defined(BUILDING_ON_LEOPARD) || defined(BUILDING_ON_SNOW_LEOPARD) || defined(WIN32)

PLATFORM(WIN), please.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1608
> +        // FIXME: This fix has not been added to the Safari Windows SDK yet (<rdar://problem/9112233>) so we expect the
> +        // reversed animation behavior

I'd say "QuartzCore on Windows" rather than "the Safari Windows SDK".
Comment 8 Chris Marrin 2011-03-11 11:19:39 PST 
Committed r80866: <http://trac.webkit.org/changeset/80866>