Bug 55936 - old-run-webkit-tests should ignore test files used by reftests
Summary: old-run-webkit-tests should ignore test files used by reftests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 67936
Blocks: 36065
  Show dependency tree / graph
 
Reported: 2011-03-08 05:03 PST by Hayato Ito
Modified: 2012-01-17 08:12 PST (History)
3 users (show)

See Also:

Attachments
ignore-reftests (1.93 KB, patch)
2011-03-08 19:23 PST, Hayato Ito 		ojan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2011-03-08 05:03:12 PST 
Please see the master bug for the rationale:
https://bugs.webkit.org/show_bug.cgi?id=36065

We are updating new-run-webkit-tests to support reftests. A old-run-webkit-tests should ignore test files used by reftests to avoid unexpected errors.
Comment 1 Hayato Ito 2011-03-08 19:23:58 PST 
Created attachment 85126 [details]
ignore-reftests
Comment 2 Ojan Vafai 2011-03-08 23:07:42 PST 
Comment on attachment 85126 [details]
ignore-reftests

View in context: https://bugs.webkit.org/attachment.cgi?id=85126&action=review

Might want to wait until bug 55457 is r+'ed to make sure that none of the paths will change.

> Tools/Scripts/old-run-webkit-tests:2460
> +

extra line break
Comment 3 Hayato Ito 2011-03-09 03:33:35 PST 
Hi Ojan,

Thank you for the review. I'll fix the extra line break and land this after 55457 is r+'ed.

(In reply to comment #2)
> (From update of attachment 85126 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85126&action=review
> 
> Might want to wait until bug 55457 is r+'ed to make sure that none of the paths will change.
> 
> > Tools/Scripts/old-run-webkit-tests:2460
> > +
> 
> extra line break
Comment 4 Hayato Ito 2011-03-16 00:51:38 PDT 
Committed r81225: <http://trac.webkit.org/changeset/81225>