Bug 55806 - WebCore GYP build should Check For Inappropriate Files in Framework
Summary: WebCore GYP build should Check For Inappropriate Files in Framework
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 55018
  Show dependency treegraph
 
Reported: 2011-03-04 17:11 PST by Adam Barth
Modified: 2011-03-04 17:44 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.76 KB, patch)
2011-03-04 17:11 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-03-04 17:11:06 PST
WebCore GYP build should Check For Inappropriate Files in Framework
Comment 1 Adam Barth 2011-03-04 17:11:39 PST
Created attachment 84834 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-03-04 17:31:49 PST
Comment on attachment 84834 [details]
Patch

This is correct. But this rule sucks.  It should remove the stuff and warn.  Otherwise these things stick around (erroring out your build!) until you clean build. :(
Comment 3 Adam Barth 2011-03-04 17:44:20 PST
Comment on attachment 84834 [details]
Patch

Clearing flags on attachment: 84834

Committed r80399: <http://trac.webkit.org/changeset/80399>
Comment 4 Adam Barth 2011-03-04 17:44:24 PST
All reviewed patches have been landed.  Closing bug.