Bug 55802 - Add skeletal WebCore.gyp
Summary: Add skeletal WebCore.gyp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 55018
  Show dependency treegraph
 
Reported: 2011-03-04 16:12 PST by Dimitri Glazkov (Google)
Modified: 2011-03-04 16:56 PST (History)
1 user (show)

See Also:


Attachments
Patch (8.28 KB, patch)
2011-03-04 16:13 PST, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff
Patch (6.94 KB, patch)
2011-03-04 16:31 PST, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff
Now added to configure script. (7.75 KB, patch)
2011-03-04 16:46 PST, Dimitri Glazkov (Google)
abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-03-04 16:12:56 PST
Add skeletal WebCore.gyp
Comment 1 Dimitri Glazkov (Google) 2011-03-04 16:13:57 PST
Created attachment 84823 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-03-04 16:31:51 PST
Created attachment 84825 [details]
Patch
Comment 3 Dimitri Glazkov (Google) 2011-03-04 16:46:55 PST
Created attachment 84829 [details]
Now added to configure script.
Comment 4 Adam Barth 2011-03-04 16:51:11 PST
Comment on attachment 84829 [details]
Now added to configure script.

View in context: https://bugs.webkit.org/attachment.cgi?id=84829&action=review

> Source/WebCore/WebCore.gypi:11
> +          'bindings',
> +          'bindings/generic',
> +          'bindings/v8',
> +          'bindings/v8/custom',
> +          'bindings/v8/specialization',

Presumably we'll need to add bindings/js at some point.

> Source/WebCore/WebCore.gypi:54
> +          'platform/image-decoders/skia',

There's some subtly here w.r.t. the various image libraries.

> Source/gyp/configure:38
> +    "WebCore"

PEP-8 says this is missing a trailing comma.
Comment 5 Adam Barth 2011-03-04 16:56:18 PST
Committed r80393: <http://trac.webkit.org/changeset/80393>