Bug 55730 - UI process needs a way to tell the web process its backing store needs a full update on the next paint
Summary: UI process needs a way to tell the web process its backing store needs a full...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks: 51262
  Show dependency tree / graph
 
Reported: 2011-03-03 17:15 PST by Adam Roben (:aroben)
Modified: 2011-03-03 17:37 PST (History)
1 user (show)

See Also:

Attachments
Patch (21.23 KB, patch)
2011-03-03 17:16 PST, Adam Roben (:aroben) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-03-03 17:15:36 PST 
UI process needs a way to tell the web process its backing store needs a full update on the next paint
Comment 1 Adam Roben (:aroben) 2011-03-03 17:16:05 PST 
Created attachment 84659 [details]
Patch
Comment 2 Anders Carlsson 2011-03-03 17:25:13 PST 
Comment on attachment 84659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84659&action=review

> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:195
> +    }

Should we do this even if there's a layer tree host?
Comment 3 Adam Roben (:aroben) 2011-03-03 17:30:49 PST 
Comment on attachment 84659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84659&action=review

>> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:195
>> +    }
> 
> Should we do this even if there's a layer tree host?

Yes. The DidUpdateBackingStoreState message will tell the UI process about the layer tree host, and won't include a bitmap.
Comment 4 Adam Roben (:aroben) 2011-03-03 17:34:19 PST 
Comment on attachment 84659 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84659&action=review

>>> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:195
>>> +    }
>> 
>> Should we do this even if there's a layer tree host?
> 
> Yes. The DidUpdateBackingStoreState message will tell the UI process about the layer tree host, and won't include a bitmap.

It will also let the UI process know we've updated to match the current state (e.g., size etc.).
Comment 5 Adam Roben (:aroben) 2011-03-03 17:37:41 PST 
Committed r80306: <http://trac.webkit.org/changeset/80306>