WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 55712
JavaScriptCore GYP build should use a header map
https://bugs.webkit.org/show_bug.cgi?id=55712
Summary
JavaScriptCore GYP build should use a header map
Adam Barth
Reported
2011-03-03 14:56:16 PST
JavaScriptCore GYP build should use a header map
Attachments
Patch
(3.75 KB, patch)
2011-03-03 14:57 PST
,
Adam Barth
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2011-03-03 14:57:51 PST
Created
attachment 84634
[details]
Patch
Dimitri Glazkov (Google)
Comment 2
2011-03-03 14:59:18 PST
Comment on
attachment 84634
[details]
Patch k
Eric Seidel (no email)
Comment 3
2011-03-03 15:00:13 PST
Comment on
attachment 84634
[details]
Patch Really? Are you sure you want this? We'll need an explicit include list for other ports anyway...
WebKit Commit Bot
Comment 4
2011-03-03 21:16:23 PST
Comment on
attachment 84634
[details]
Patch Rejecting
attachment 84634
[details]
from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 2 Last 500 characters of output: ). 1 out of 2 hunks FAILED -- saving rejects to file Source/JavaScriptCore/JavaScriptCore.gypi.rej patching file Source/JavaScriptCore/gyp/JavaScriptCore.gyp Hunk #1 succeeded at 110 (offset 3 lines). Hunk #2 FAILED at 195. Hunk #3 FAILED at 216. Hunk #4 FAILED at 238. 3 out of 4 hunks FAILED -- saving rejects to file Source/JavaScriptCore/gyp/JavaScriptCore.gyp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--..." exit_code: 1 Full output:
http://queues.webkit.org/results/8086447
Adam Barth
Comment 5
2011-03-04 11:21:40 PST
Comment on
attachment 84634
[details]
Patch Clearing flags on attachment: 84634 Committed
r80368
: <
http://trac.webkit.org/changeset/80368
>
Adam Barth
Comment 6
2011-03-04 11:21:44 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7
2011-03-04 12:57:30 PST
http://trac.webkit.org/changeset/80368
might have broken GTK Linux 32-bit Release
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug