RESOLVED FIXED 55686
Web Inspector: [Extensions API] maintain own, unique & persistent identifiers for resources
https://bugs.webkit.org/show_bug.cgi?id=55686
Summary Web Inspector: [Extensions API] maintain own, unique & persistent identifiers...
Andrey Kosyakov
Reported 2011-03-03 10:07:25 PST
Extension server currently relies on resource identifiers used by NetworkManager and NetworkPanel -- this causes problems when we change these identifiers as a result of redirect. We should use identifiers that are unique and don't change through lifetime of an object.
Attachments
patch (8.42 KB, patch)
2011-03-03 10:13 PST, Andrey Kosyakov
no flags
Andrey Kosyakov
Comment 1 2011-03-03 10:13:54 PST
WebKit Commit Bot
Comment 2 2011-03-04 08:35:49 PST
The commit-queue encountered the following flaky tests while processing attachment 84581 [details]: inspector/audits/audits-panel-functional.html bug 55776 (authors: apavlov@chromium.org, pfeldman@chromium.org, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 3 2011-03-04 08:37:42 PST
Comment on attachment 84581 [details] patch Clearing flags on attachment: 84581 Committed r80355: <http://trac.webkit.org/changeset/80355>
WebKit Commit Bot
Comment 4 2011-03-04 08:37:48 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2011-03-04 09:17:07 PST
http://trac.webkit.org/changeset/80355 might have broken Qt Linux Release The following tests are not passing: http/tests/inspector/console-xhr-logging.html http/tests/inspector/network-preflight-options.html http/tests/inspector/resource-parameters.html inspector/console/command-line-api-inspect.html inspector/console/command-line-api.html inspector/console/console-api-on-call-frame.html inspector/console/console-assert.html inspector/console/console-command-clear.html inspector/console/console-eval-global.html inspector/console/console-eval.html inspector/console/console-format.html inspector/console/console-substituted.html inspector/cpu-profiler-profiling.html inspector/debugger/debug-inlined-scripts.html inspector/debugger/debugger-autocontinue-on-syntax-error.html inspector/debugger/debugger-scripts.html inspector/debugger/debugger-suspend-active-dom-objects.html inspector/debugger/scripts-panel.html inspector/debugger/source-frame.html inspector/elements/elements-img-tooltip.html inspector/elements/elements-panel-limited-children.html inspector/elements/elements-panel-styles.html inspector/extensions/extensions-resources.html inspector/storage-panel-dom-storage.html inspector/styles/styles-computed-trace.html inspector/styles/styles-disable-inherited.html inspector/timeline/timeline-event-dispatch.html inspector/timeline/timeline-mark-timeline.html inspector/timeline/timeline-script-tag-2.html
Note You need to log in before you can comment on or make changes to this bug.