Bug 55549 - Remove efl port style exception of Webcore/JavaScriptCore
Summary: Remove efl port style exception of Webcore/JavaScriptCore
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Gyuyoung Kim
Depends on:
Reported: 2011-03-01 20:26 PST by Gyuyoung Kim
Modified: 2011-03-07 00:17 PST (History)
6 users (show)

See Also:

Patch (1.18 KB, patch)
2011-03-01 20:28 PST, Gyuyoung Kim
tkent: review+
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
Patch (1.21 KB, patch)
2011-03-01 20:37 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2011-03-01 20:26:53 PST
As mentioned in Bug 55292 comment #3, WebCore and JavaScriptCore need to adhere WebKit coding style.
Comment 1 Gyuyoung Kim 2011-03-01 20:28:47 PST
Created attachment 84360 [details]
Comment 2 WebKit Review Bot 2011-03-01 20:30:53 PST
Attachment 84360 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1

Traceback (most recent call last):
  File "Tools/Scripts/check-webkit-style", line 52, in <module>
    import webkitpy.style.checker as checker
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 172
SyntaxError: invalid syntax

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kent Tamura 2011-03-01 20:33:21 PST
Comment on attachment 84360 [details]

Looks good.
Comment 4 Gyuyoung Kim 2011-03-01 20:35:26 PST
Comment on attachment 84360 [details]

There is a syntax problem. I'm going to upload new patch soon with your name.
Comment 5 Gyuyoung Kim 2011-03-01 20:37:41 PST
Created attachment 84361 [details]

I fix style error.
Comment 6 WebKit Commit Bot 2011-03-01 22:29:07 PST
Comment on attachment 84361 [details]

Clearing flags on attachment: 84361

Committed r80095: <http://trac.webkit.org/changeset/80095>