Bug 55292 – [EFL] Restore parameters of efl header files.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gyuyoung Kim]

This patch restores parameters in efl header files.

[Gyuyoung Kim]

Created attachment 83927 [details]
Proposed Patch

[WebKit Review Bot]

Attachment 83927 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Last 3072 characters of output:
name "ev" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/efl/ewk/ewk_frame.h:223:  The parameter name "o" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/efl/ewk/ewk_frame.h:224:  The parameter name "o" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/efl/ewk/ewk_frame.h:224:  The parameter name "ev" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/efl/ewk/ewk_frame.h:225:  The parameter name "o" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/efl/ewk/ewk_frame.h:225:  The parameter name "ev" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/efl/ewk/ewk_tiled_model.h:30:  The parameter name "evas" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/efl/ewk/ewk_tiled_model.h:31:  The parameter name "t" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/efl/ewk/ewk_tiled_model.h:33:  The parameter name "t" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/efl/ewk/ewk_tiled_model.h:34:  The parameter name "t" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/efl/ewk/ewk_tiled_model.h:35:  The parameter name "t" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/efl/ewk/ewk_tiled_model.h:36:  The parameter name "t" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/efl/ewk/ewk_tiled_model.h:37:  The parameter name "t" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/efl/ewk/ewk_tiled_model.h:37:  The parameter name "r" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/efl/ewk/ewk_tiled_model.h:38:  The parameter name "t" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/efl/ewk/ewk_tiled_model.h:39:  The parameter name "t" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/efl/ewk/ewk_tiled_model.h:54:  The parameter name "t" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/efl/ewk/ewk_tiled_model.h:55:  The parameter name "t" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/efl/ewk/ewk_tiled_matrix.h:40:  The parameter name "evas" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/efl/ewk/ewk_tiled_matrix.h:41:  The parameter name "t" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/efl/ewk/ewk_tiled_matrix.h:45:  The parameter name "t" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 274 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kenneth Rohde Christiansen]

Comment on attachment 83927 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83927&action=review

> Source/WebCore/platform/efl/RenderThemeEfl.h:104
> -    void adjustSizeConstraints(RenderStyle*, FormType) const;
> +    void adjustSizeConstraints(RenderStyle* style, FormType type) const;

This is not a public EFL header file, so you should really use webkit style

> Source/WebKit/efl/ChangeLog:5
> +        [EFL] Restore parameters of efl header files.

You should only do that to public EFL header files. The reason why EFL wants a different style, is because these headers are installed on the system and serves as API documentation.

[Gyuyoung Kim]

Bug 54733 was landed. So, removed parameters should be restored.

[Gyuyoung Kim]

Created attachment 84000 [details]
Patch

I'd like to restore parameters in ewk header files before other patches are landed.

[Kent Tamura]

Comment on attachment 84000 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84000&action=review

> Source/WebCore/ChangeLog:10
> +        * platform/efl/RenderThemeEfl.h:

I agree with Kenneth.  WebCore files should follow WebKit style.

[Gyuyoung Kim]

Created attachment 84007 [details]
Patch

Ok, according to this bug tittle, I only restore ewk header files. I will discuss how to follow coding style of WebCore's efl port in new bug.

[WebKit Commit Bot]

Comment on attachment 84007 [details]
Patch

Clearing flags on attachment: 84007

Committed r79838: <http://trac.webkit.org/changeset/79838>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.