Bug 55524 - JavaScriptCore GYP build should copy some headers into the target framework
Summary: JavaScriptCore GYP build should copy some headers into the target framework
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 55018
  Show dependency treegraph
 
Reported: 2011-03-01 16:27 PST by Adam Barth
Modified: 2011-03-01 22:14 PST (History)
3 users (show)

See Also:


Attachments
Patch (32.40 KB, patch)
2011-03-01 16:29 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-03-01 16:27:01 PST
JavaScriptCore GYP build should copy some headers into the target framework
Comment 1 Adam Barth 2011-03-01 16:29:25 PST
Created attachment 84321 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-03-01 16:42:16 PST
Comment on attachment 84321 [details]
Patch

Yeah, I'm not a big fan here.  Seems like we should have a separate (identical) list of "private" and "public" headers in the gypi.  You could no longer auto-gen this gypi list from the file system for example.

But I think these are also things we can make better decisions on as we get further in this process.
Comment 3 Adam Barth 2011-03-01 16:51:51 PST
My understanding is that the prolific private headers are only required because of the ForwardingHeaders design.  Once we change the Apple-internal submission script to submit the Source directory instead of the individual frameworks, then I suspect we'll be able to remove most (if not all) of the private headers.
Comment 4 WebKit Commit Bot 2011-03-01 22:11:26 PST
The commit-queue encountered the following flaky tests while processing attachment 84321 [details]:

inspector/debugger/debugger-breakpoints-not-activated-on-reload.html bug 55551 (authors: pfeldman@chromium.org and podivilov@chromium.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2011-03-01 22:14:33 PST
Comment on attachment 84321 [details]
Patch

Clearing flags on attachment: 84321

Committed r80094: <http://trac.webkit.org/changeset/80094>
Comment 6 WebKit Commit Bot 2011-03-01 22:14:38 PST
All reviewed patches have been landed.  Closing bug.