Bug 55523 - Fix a bug in platform/mac/editing/input/selection-change-closes-typing.html
Summary: Fix a bug in platform/mac/editing/input/selection-change-closes-typing.html
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 56588
Blocks: 51389
  Show dependency tree / graph
 
Reported: 2011-03-01 16:19 PST by Ryosuke Niwa
Modified: 2011-03-17 15:44 PDT (History)
2 users (show)

See Also:

Attachments
fixes the bug (1.30 KB, patch)
2011-03-01 16:22 PST, Ryosuke Niwa 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-03-01 16:19:45 PST 
In platform/mac/editing/input/selection-change-closes-typing.html,

we do:

textInputController.setMarkedText("P", 1, 0);
testInput.value="PAS";
eventSender.keyDown("S");

but it should read:

textInputController.setMarkedText("P", 0, 1);
testInput.value="PAS";
eventSender.keyDown("S");

because textInput initially has no value, and the marked text must be inserted at offset 0 with length 1, not at offset 1 with length 0.
Comment 1 Ryosuke Niwa 2011-03-01 16:22:39 PST 
Created attachment 84320 [details]
fixes the bug
Comment 2 Ryosuke Niwa 2011-03-01 16:38:27 PST 
Thanks for the review, Alexey!
Comment 3 Ryosuke Niwa 2011-03-01 16:45:18 PST 
Committed r80064: <http://trac.webkit.org/changeset/80064>
Comment 4 Alexey Proskuryakov 2011-03-17 15:35:55 PDT 
This got reverted in bug 56588.