RESOLVED INVALID 55523
Fix a bug in platform/mac/editing/input/selection-change-closes-typing.html 
https://bugs.webkit.org/show_bug.cgi?id=55523
Summary Fix a bug in platform/mac/editing/input/selection-change-closes-typing.html
Ryosuke Niwa
Reported 2011-03-01 16:19:45 PST
In platform/mac/editing/input/selection-change-closes-typing.html, we do: textInputController.setMarkedText("P", 1, 0); testInput.value="PAS"; eventSender.keyDown("S"); but it should read: textInputController.setMarkedText("P", 0, 1); testInput.value="PAS"; eventSender.keyDown("S"); because textInput initially has no value, and the marked text must be inserted at offset 0 with length 1, not at offset 1 with length 0.
Attachments
fixes the bug (1.30 KB, patch)
2011-03-01 16:22 PST, Ryosuke Niwa 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-03-01 16:22:39 PST
Created attachment 84320 [details] fixes the bug
Ryosuke Niwa
Comment 2 2011-03-01 16:38:27 PST
Thanks for the review, Alexey!
Ryosuke Niwa
Comment 3 2011-03-01 16:45:18 PST
Committed r80064: <http://trac.webkit.org/changeset/80064>
Alexey Proskuryakov
Comment 4 2011-03-17 15:35:55 PDT
This got reverted in bug 56588.
Note You need to log in before you can comment on or make changes to this bug.