Bug 55507 - Add pre- and post-build actions for JavaScriptCore GYP build
Summary: Add pre- and post-build actions for JavaScriptCore GYP build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 55018
  Show dependency tree / graph
 
Reported: 2011-03-01 14:19 PST by Adam Barth
Modified: 2019-05-02 16:23 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.32 KB, patch)
2011-03-01 14:31 PST, Adam Barth 		abarth: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-03-01 14:19:06 PST 
Add pre- and post-build actions for JavaScriptCore GYP build
Comment 1 Adam Barth 2011-03-01 14:31:40 PST 
Created attachment 84295 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-03-01 14:49:40 PST 
Comment on attachment 84295 [details]
Patch

Lovely.
Comment 3 Mark Rowe (bdash) 2011-03-01 15:02:07 PST 
Comment on attachment 84295 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84295&action=review

> Source/gyp/common.gypi:12
> +            'sh', '<(DEPTH)/gyp/update-info-plist.sh', '<(DEPTH)/JavaScriptGlue/Info.plist'

Why is a common file always working with JavaScriptGlue’s Info.plist?
Comment 4 Adam Barth 2011-03-01 15:20:20 PST 
Comment on attachment 84295 [details]
Patch

Sounds like a bug.
Comment 5 Adam Barth 2011-03-01 16:48:16 PST 
Committed r80065: <http://trac.webkit.org/changeset/80065>