Bug 55425 - Teach JavaScriptCore GYP build about DEPTH
Summary: Teach JavaScriptCore GYP build about DEPTH
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 55018
  Show dependency treegraph
 
Reported: 2011-02-28 16:39 PST by Adam Barth
Modified: 2011-03-01 00:14 PST (History)
3 users (show)

See Also:


Attachments
Patch (4.30 KB, patch)
2011-02-28 16:40 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-02-28 16:39:35 PST
Teach JavaScriptCore GYP build about DEPTH
Comment 1 Adam Barth 2011-02-28 16:40:47 PST
Created attachment 84150 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-02-28 23:55:23 PST
Comment on attachment 84150 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84150&action=review

> Source/JavaScriptCore/gyp/JavaScriptCore.gyp:27
> +        '<(DEPTH)', # Some paths in API include JavaScriptCore/
> +        '<(DEPTH)/JavaScriptCore',
> +        '<(DEPTH)/JavaScriptCore/ForwardingHeaders',
> +        '<(DEPTH)/JavaScriptCore/API',
> +        '<(DEPTH)/JavaScriptCore/assembler',
> +        '<(DEPTH)/JavaScriptCore/collector/handles',
> +        '<(DEPTH)/JavaScriptCore/bytecode',
> +        '<(DEPTH)/JavaScriptCore/bytecompiler',
> +        '<(DEPTH)/JavaScriptCore/debugger',
> +        '<(DEPTH)/JavaScriptCore/icu',
> +        '<(DEPTH)/JavaScriptCore/interpreter',
> +        '<(DEPTH)/JavaScriptCore/jit',
> +        '<(DEPTH)/JavaScriptCore/parser',
> +        '<(DEPTH)/JavaScriptCore/profiler',
> +        '<(DEPTH)/JavaScriptCore/runtime',
> +        '<(DEPTH)/JavaScriptCore/wtf',
> +        '<(DEPTH)/JavaScriptCore/wtf/unicode',

This seems annoyingly verbose.  Would be nice to have an INCLUDE_ROOT feature for gyp. :)
Comment 3 Adam Barth 2011-03-01 00:06:58 PST
We can create an INCLUDE_ROOT variable pretty easily.
Comment 4 Eric Seidel (no email) 2011-03-01 00:12:02 PST
I mean so that we don't have to use DEPTH for every include line.
Comment 5 WebKit Commit Bot 2011-03-01 00:14:46 PST
Comment on attachment 84150 [details]
Patch

Clearing flags on attachment: 84150

Committed r79974: <http://trac.webkit.org/changeset/79974>
Comment 6 WebKit Commit Bot 2011-03-01 00:14:51 PST
All reviewed patches have been landed.  Closing bug.