Bug 55417 - RunLoop::Timer fires 1000x too early on Windows
Summary: RunLoop::Timer fires 1000x too early on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks: 51262
  Show dependency tree / graph
 
Reported: 2011-02-28 15:18 PST by Adam Roben (:aroben)
Modified: 2011-03-01 07:30 PST (History)
1 user (show)

See Also:

Attachments
Convert seconds to milliseconds before calling ::SetTimer (17.91 KB, patch)
2011-03-01 07:25 PST, Adam Roben (:aroben) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-02-28 15:18:51 PST 
RunLoop::Timer fires 1000x too early on Windows. We're making a seconds vs. milliseconds conversion error. Right now this only affects the responsiveness timer (all other timers are 0-delay).
Comment 1 Adam Roben (:aroben) 2011-02-28 15:20:07 PST 
This is blocking bug 51262, which wants to add a new non-0-delay timer.
Comment 2 Adam Roben (:aroben) 2011-02-28 15:20:39 PST 
<rdar://problem/9065287>
Comment 3 Adam Roben (:aroben) 2011-03-01 07:25:38 PST 
Created attachment 84228 [details]
Convert seconds to milliseconds before calling ::SetTimer
Comment 4 Adam Roben (:aroben) 2011-03-01 07:30:27 PST 
Committed r80001: <http://trac.webkit.org/changeset/80001>