Bug 55141 - FETurbulenceElement changes doesn't require relayout.
Summary: FETurbulenceElement changes doesn't require relayout.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Renata Hodovan
URL:
Keywords:
Depends on:
Blocks: 55075
  Show dependency treegraph
 
Reported: 2011-02-24 06:48 PST by Renata Hodovan
Modified: 2011-02-28 03:31 PST (History)
2 users (show)

See Also:


Attachments
Proposed patch (10.13 KB, patch)
2011-02-25 04:34 PST, Renata Hodovan
zimmermann: review+
Details | Formatted Diff | Diff
Proposed patch (10.24 KB, patch)
2011-02-25 06:24 PST, Renata Hodovan
kling: review+
kling: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Renata Hodovan 2011-02-24 06:48:57 PST
FETurbulenceElement changes doesn't require relayout.
Comment 1 Renata Hodovan 2011-02-25 04:34:27 PST
Created attachment 83795 [details]
Proposed patch
Comment 2 Build Bot 2011-02-25 04:58:50 PST
Attachment 83795 [details] did not build on win:
Build output: http://queues.webkit.org/results/8023003
Comment 3 Nikolas Zimmermann 2011-02-25 05:01:59 PST
Comment on attachment 83795 [details]
Proposed patch

r=me.
Comment 4 Andreas Kling 2011-02-25 05:46:51 PST
Comment on attachment 83795 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83795&action=review

> Source/WebCore/platform/graphics/filters/FETurbulence.cpp:128
> +    if (m_numOctaves == numOctaves)
> +        return false;

m_numOctaves is int, this should be fixed before landing this (as this will break Windows judging by EWS.)
Comment 5 Renata Hodovan 2011-02-25 05:49:09 PST
(In reply to comment #4)
> (From update of attachment 83795 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=83795&action=review
> 
> > Source/WebCore/platform/graphics/filters/FETurbulence.cpp:128
> > +    if (m_numOctaves == numOctaves)
> > +        return false;
> 
> m_numOctaves is int, this should be fixed before landing this (as this will break Windows judging by EWS.)

Yeah, i see it already and supplement the patch immediately.
Comment 6 Renata Hodovan 2011-02-25 06:24:09 PST
Created attachment 83799 [details]
Proposed patch

Fix the parameter type of FETurbulence::setNumOctaves which caused the broken WIN bot.
Comment 7 Andreas Kling 2011-02-28 03:11:35 PST
Comment on attachment 83799 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83799&action=review

r=me, but please update the symbols in Source/WebCore/WebCore.order wrt TurbulanceType/TurbulenceType as well.

> Source/WebCore/ChangeLog:13
> +        No new tests are needed because this modificiation is covered by the dynamic update tests of FETurbulence.

Typo, modification.
Comment 8 Renata Hodovan 2011-02-28 03:31:29 PST
Committed r79851: <http://trac.webkit.org/changeset/79851>