Bug 55141 – FETurbulenceElement changes doesn't require relayout.

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Renata Hodovan]

FETurbulenceElement changes doesn't require relayout.

[Renata Hodovan]

Created attachment 83795 [details]
Proposed patch

[Build Bot]

Attachment 83795 [details] did not build on win:
Build output: http://queues.webkit.org/results/8023003

[Nikolas Zimmermann]

Comment on attachment 83795 [details]
Proposed patch

r=me.

[Andreas Kling]

Comment on attachment 83795 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83795&action=review

> Source/WebCore/platform/graphics/filters/FETurbulence.cpp:128
> +    if (m_numOctaves == numOctaves)
> +        return false;

m_numOctaves is int, this should be fixed before landing this (as this will break Windows judging by EWS.)

[Renata Hodovan]

(In reply to comment #4)
> (From update of attachment 83795 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=83795&action=review
> 
> > Source/WebCore/platform/graphics/filters/FETurbulence.cpp:128
> > +    if (m_numOctaves == numOctaves)
> > +        return false;
> 
> m_numOctaves is int, this should be fixed before landing this (as this will break Windows judging by EWS.)

Yeah, i see it already and supplement the patch immediately.

[Renata Hodovan]

Created attachment 83799 [details]
Proposed patch

Fix the parameter type of FETurbulence::setNumOctaves which caused the broken WIN bot.

[Andreas Kling]

Comment on attachment 83799 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83799&action=review

r=me, but please update the symbols in Source/WebCore/WebCore.order wrt TurbulanceType/TurbulenceType as well.

> Source/WebCore/ChangeLog:13
> +        No new tests are needed because this modificiation is covered by the dynamic update tests of FETurbulence.

Typo, modification.

[Renata Hodovan]

Committed r79851: <http://trac.webkit.org/changeset/79851>