Bug 54708 - webkitpy.layout_tests.port.mock_drt_unittest fails on win32
Summary: webkitpy.layout_tests.port.mock_drt_unittest fails on win32
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-17 18:58 PST by Dirk Pranke
Modified: 2011-02-18 15:40 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.62 KB, patch)
2011-02-17 19:01 PST, Dirk Pranke 		aroben: review+
Details | Formatted Diff | Diff
Patch (2.20 KB, patch)
2011-02-17 19:05 PST, Dirk Pranke 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-02-17 18:58:44 PST 
the unit test attempts to mock out the default port on the platform, but the default on 'win32', rightly or wrongly, is 'win', and not 'chromium-win'. And 'win' doesn't work - see bug 38756.
Comment 1 Dirk Pranke 2011-02-17 19:01:25 PST 
Created attachment 82894 [details]
Patch
Comment 2 Dirk Pranke 2011-02-17 19:05:04 PST 
Created attachment 82896 [details]
Patch
Comment 3 Dirk Pranke 2011-02-17 19:07:16 PST 
Comment on attachment 82896 [details]
Patch

darn ... wrong bug.
Comment 4 Adam Roben (:aroben) 2011-02-17 19:38:10 PST 
Comment on attachment 82894 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82894&action=review

> Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:46
> +        if sys.platform == 'win32':
> +            return mock_drt.MockDRTPort(port_name='mock-chromium-win')

You could add a FIXME here referencing bug 48728 and a desire to test both chromium-win and win.
Comment 5 Dirk Pranke 2011-02-18 15:40:28 PST 
Committed r79041: <http://trac.webkit.org/changeset/79041>