WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 25592
54663
Stop using RenderThemeSafari when running regression tests
https://bugs.webkit.org/show_bug.cgi?id=54663
Summary
Stop using RenderThemeSafari when running regression tests
Adam Roben (:aroben)
Reported
2011-02-17 08:02:25 PST
DumpRenderTree and WebKitTestRunner use RenderThemeSafari instead of RenderThemeWin. This is good for sharing results with Mac, but bad for testing the code that actually runs on users machines. It's also a maintenance burden; as new form controls are added, support for them needs to be added to RenderThemeSafari, even though users will never see that version of the form control! (E.g.,
bug 48690
,
bug 54662
) We should probably switch from using RenderThemeSafari to using RenderThemeWin when running regression tests. Unfortunately this will mean having more Windows-specific results. But it's just silly not to be testing code that users actually use.
Attachments
Add attachment
proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1
2011-02-17 08:02:55 PST
<
rdar://problem/9017127
>
Adam Roben (:aroben)
Comment 2
2011-04-07 08:30:04 PDT
*** This bug has been marked as a duplicate of
bug 25592
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug