Bug 54622 – Rename Position::node() to Position::deprecatedNode()

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Ryosuke Niwa]

I changed my mind.  I used to think that this will unnecessarily pollute svn blame.  However, I realized that it's extremely hard to recognize all call sites of Position::node() in the presence of RenderObject::node()

[Ryosuke Niwa]

Created attachment 82765 [details]
r? to see build errors on non-Mac ports

[WebKit Review Bot]

Attachment 82765 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Last 3072 characters of output:
he left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/editing/ReplaceSelectionCommand.cpp:796:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/editing/CompositeEditCommand.cpp:732:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
Source/WebCore/editing/DeleteSelectionCommand.cpp:510:  Declaration has space between type name and * in Text *text  [whitespace/declaration] [3]
Source/WebCore/editing/DeleteSelectionCommand.cpp:523:  Declaration has space between type name and * in Node *n  [whitespace/declaration] [3]
Source/WebCore/dom/Position.cpp:390:  Declaration has space between type name and * in RenderText *textRenderer  [whitespace/declaration] [3]
Source/WebCore/dom/Position.cpp:411:  Declaration has space between type name and * in Node *fromRootEditableElement  [whitespace/declaration] [3]
Source/WebCore/dom/Position.cpp:439:  Declaration has space between type name and * in Node *fromRootEditableElement  [whitespace/declaration] [3]
Source/WebCore/dom/Position.cpp:767:  Declaration has space between type name and * in RenderObject *renderer  [whitespace/declaration] [3]
Source/WebCore/dom/Position.cpp:803:  Declaration has space between type name and * in RenderObject *renderer  [whitespace/declaration] [3]
Source/WebCore/dom/Position.cpp:863:  Declaration has space between type name and * in RenderObject *renderer  [whitespace/declaration] [3]
Source/WebCore/dom/Position.cpp:867:  Declaration has space between type name and * in RenderObject *posRenderer  [whitespace/declaration] [3]
Source/WebCore/dom/Position.cpp:931:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/dom/Position.cpp:932:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/dom/Position.cpp:936:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/dom/Position.cpp:937:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/editing/ApplyStyleCommand.cpp:673:  Declaration has space between type name and * in Node *startNode  [whitespace/declaration] [3]
Source/WebCore/editing/htmlediting.cpp:886:  Declaration has space between type name and * in Node *node  [whitespace/declaration] [3]
Source/WebCore/editing/InsertTextCommand.cpp:171:  Declaration has space between type name and * in Text *textNode  [whitespace/declaration] [3]
Source/WebCore/editing/InsertTextCommand.cpp:212:  Declaration has space between type name and * in Node *node  [whitespace/declaration] [3]
Total errors found: 31 in 44 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Attachment 82765 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7926605

[Collabora GTK+ EWS bot]

Attachment 82765 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7917765

[Ryosuke Niwa]

Created attachment 82774 [details]
second attempt; r? to see build errors on non-Mac ports

[Collabora GTK+ EWS bot]

Attachment 82774 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7920690

[WebKit Review Bot]

Attachment 82774 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7917783

[Ryosuke Niwa]

Created attachment 82779 [details]
3rd attempt; r? to see build errors on non-Mac ports

[WebKit Review Bot]

Attachment 82765 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7927591

[Collabora GTK+ EWS bot]

Attachment 82779 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7920700

[Ryosuke Niwa]

Created attachment 82781 [details]
4th attempt

[Kent Tamura]

Comment on attachment 82781 [details]
4th attempt

ok

[Ryosuke Niwa]

Committed r79196: <http://trac.webkit.org/changeset/79196>