Bug 54593 - flaky test archive uploads are always 22 bytes long
Summary: flaky test archive uploads are always 22 bytes long
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-16 15:23 PST by Eric Seidel (no email)
Modified: 2011-02-16 19:49 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.03 KB, patch)
2011-02-16 15:26 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch for landing (3.09 KB, patch)
2011-02-16 15:41 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-02-16 15:23:53 PST 
flaky test archive uploads are always 22 bytes long

I'm not entirely sure why, but I think we may need to seek the file pointer back to 0 before passing it to mechanize.

Example failures:
https://bugs.webkit.org/show_bug.cgi?id=51138
https://bugs.webkit.org/show_bug.cgi?id=54404
https://bugs.webkit.org/show_bug.cgi?id=54324
Comment 1 Eric Seidel (no email) 2011-02-16 15:26:13 PST 
Created attachment 82709 [details]
Patch
Comment 2 Mihai Parparita 2011-02-16 15:31:28 PST 
Comment on attachment 82709 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=82709&action=review

> Tools/Scripts/webkitpy/tool/bot/flakytestreporter.py:176
> +            file_object = results_archive.fp

Maybe rename results_archive to results_archive_zip and file_object to results_archive_file to make this more clear?
Comment 3 Eric Seidel (no email) 2011-02-16 15:41:13 PST 
Created attachment 82713 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2011-02-16 19:49:02 PST 
Comment on attachment 82713 [details]
Patch for landing

Clearing flags on attachment: 82713

Committed r78779: <http://trac.webkit.org/changeset/78779>
Comment 5 WebKit Commit Bot 2011-02-16 19:49:06 PST 
All reviewed patches have been landed.  Closing bug.