RESOLVED FIXED54593
flaky test archive uploads are always 22 bytes long 
https://bugs.webkit.org/show_bug.cgi?id=54593
Summary flaky test archive uploads are always 22 bytes long
Eric Seidel (no email)
Reported 2011-02-16 15:23:53 PST
flaky test archive uploads are always 22 bytes long I'm not entirely sure why, but I think we may need to seek the file pointer back to 0 before passing it to mechanize. Example failures: https://bugs.webkit.org/show_bug.cgi?id=51138 https://bugs.webkit.org/show_bug.cgi?id=54404 https://bugs.webkit.org/show_bug.cgi?id=54324
Attachments
Patch (2.03 KB, patch)
2011-02-16 15:26 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.09 KB, patch)
2011-02-16 15:41 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-02-16 15:26:13 PST
Created attachment 82709 [details] Patch
Mihai Parparita
Comment 2 2011-02-16 15:31:28 PST
Comment on attachment 82709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82709&action=review > Tools/Scripts/webkitpy/tool/bot/flakytestreporter.py:176 > + file_object = results_archive.fp Maybe rename results_archive to results_archive_zip and file_object to results_archive_file to make this more clear?
Eric Seidel (no email)
Comment 3 2011-02-16 15:41:13 PST
Created attachment 82713 [details] Patch for landing
WebKit Commit Bot
Comment 4 2011-02-16 19:49:02 PST
Comment on attachment 82713 [details] Patch for landing Clearing flags on attachment: 82713 Committed r78779: <http://trac.webkit.org/changeset/78779>
WebKit Commit Bot
Comment 5 2011-02-16 19:49:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.