RESOLVED FIXED Bug 54536
Improve showTree of Range, Position, and VisiblePosition 
https://bugs.webkit.org/show_bug.cgi?id=54536
Summary Improve showTree of Range, Position, and VisiblePosition
Ryosuke Niwa
Reported 2011-02-16 01:16:59 PST
We should enhance showTree of Range, Position, and VisiblePosition so that it doesn't use deprecatedEditingOffset. We should also update showTree of Position and VisiblePosition to dump anchor type and other useful information.
Attachments
Patch (9.22 KB, patch)
2011-02-16 01:22 PST, Ryosuke Niwa 		tkent: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-02-16 01:22:34 PST
Created attachment 82603 [details] Patch
Kent Tamura
Comment 2 2011-02-16 17:37:05 PST
Comment on attachment 82603 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82603&action=review > Source/WebCore/dom/Position.cpp:1240 > + fprintf(stderr, "legacy, "); nit: You can use fputs() for fixed strings.
Ryosuke Niwa
Comment 3 2011-02-16 18:10:10 PST
Thanks for the review, Kent! (In reply to comment #2) > (From update of attachment 82603 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=82603&action=review > > > Source/WebCore/dom/Position.cpp:1240 > > + fprintf(stderr, "legacy, "); > > nit: You can use fputs() for fixed strings. Fixed.
Ryosuke Niwa
Comment 4 2011-02-16 18:33:04 PST
Committed r78761: <http://trac.webkit.org/changeset/78761>
Note You need to log in before you can comment on or make changes to this bug.