This is a cleanup.
Created attachment 82400 [details] 54425
Comment on attachment 82400 [details] 54425 View in context: https://bugs.webkit.org/attachment.cgi?id=82400&action=review Seems OK. Not sure it needs to be a member function. I don’t see uses of data or function members. If I am right it could be a static member function or event a non-member function. Non-member would be good because we wouldn’t have to touch the header file. > Source/WebCore/dom/Range.cpp:866 > + return clonedContainer; Should be clonedContainer.release().
(In reply to comment #2) > (From update of attachment 82400 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=82400&action=review > > Seems OK. Not sure it needs to be a member function. I don’t see uses of data or function members. If I am right it could be a static member function or event a non-member function. Non-member would be good because we wouldn’t have to touch the header file. The reason this function had to be a member function was because ActionType is declared private. I could make ActionType public as well but then it seems to unnecessarily pollute WebCore namespace.
(In reply to comment #3) > The reason this function had to be a member function was because ActionType is declared private. OK. It can be a static member function, then.
(In reply to comment #4) > (In reply to comment #3) > > The reason this function had to be a member function was because ActionType is declared private. > > OK. It can be a static member function, then. Yes, I'll make processContentsBetweenOffsets and processAncestorsAndTheirSiblings static functions before landing it. Thanks for the review!
Created attachment 82561 [details] Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 82561 [details]: media/invalid-media-url-crash.html bug 51138 (author: inferno@chromium.org) The commit-queue is continuing to process your patch.
Comment on attachment 82561 [details] Patch for landing Clearing flags on attachment: 82561 Committed r78679: <http://trac.webkit.org/changeset/78679>
All reviewed patches have been landed. Closing bug.