Bug 54425 – Extract a function to process ancestor and their sibling nodes from processContents

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

This is a cleanup.

[Ryosuke Niwa]

Created attachment 82400 [details]
54425

[Darin Adler]

Comment on attachment 82400 [details]
54425

View in context: https://bugs.webkit.org/attachment.cgi?id=82400&action=review

Seems OK. Not sure it needs to be a member function. I don’t see uses of data or function members. If I am right it could be a static member function or event a non-member function. Non-member would be good because we wouldn’t have to touch the header file.

> Source/WebCore/dom/Range.cpp:866
> +    return clonedContainer;

Should be clonedContainer.release().

[Ryosuke Niwa]

(In reply to comment #2)
> (From update of attachment 82400 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=82400&action=review
> 
> Seems OK. Not sure it needs to be a member function. I don’t see uses of data or function members. If I am right it could be a static member function or event a non-member function. Non-member would be good because we wouldn’t have to touch the header file.

The reason this function had to be a member function was because ActionType is declared private.  I could make ActionType public as well but then it seems to unnecessarily pollute WebCore namespace.

[Darin Adler]

(In reply to comment #3)
> The reason this function had to be a member function was because ActionType is declared private.

OK. It can be a static member function, then.

[Ryosuke Niwa]

(In reply to comment #4)
> (In reply to comment #3)
> > The reason this function had to be a member function was because ActionType is declared private.
> 
> OK. It can be a static member function, then.

Yes, I'll make processContentsBetweenOffsets and processAncestorsAndTheirSiblings static functions before landing it.

Thanks for the review!

[Ryosuke Niwa]

Created attachment 82561 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 82561 [details]:

media/invalid-media-url-crash.html bug 51138 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 82561 [details]
Patch for landing

Clearing flags on attachment: 82561

Committed r78679: <http://trac.webkit.org/changeset/78679>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.