Bug 54192 - [Qt] Add UrlLoader and command line argument handling to MiniBrowser
Summary: [Qt] Add UrlLoader and command line argument handling to MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-10 05:12 PST by Zoltan Horvath
Modified: 2011-02-10 06:21 PST (History)
2 users (show)

See Also:


Attachments
proposed patch (26.59 KB, patch)
2011-02-10 05:14 PST, Zoltan Horvath
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2011-02-10 05:12:56 PST
Copy and modify files from QtTestBrowser's implementation.
Comment 1 Zoltan Horvath 2011-02-10 05:14:23 PST
Created attachment 81953 [details]
proposed patch
Comment 2 WebKit Review Bot 2011-02-10 05:16:18 PST
Attachment 81953 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/MiniBrowser/qt/B..." exit_code: 1

Tools/MiniBrowser/qt/utils.cpp:29:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Tools/MiniBrowser/qt/UrlLoader.cpp:29:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:29:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2011-02-10 05:45:23 PST
Comment on attachment 81953 [details]
proposed patch

Wohoo, moar QtMiniBrowser! r=me
Comment 4 Zoltan Horvath 2011-02-10 05:59:38 PST
(In reply to comment #2)

> If any of these errors are false positives, please file a bug against check-webkit-style.

Bug #54200 filed!
Comment 5 Zoltan Horvath 2011-02-10 06:21:01 PST
Thanks for review!
Committed r78217
http://trac.webkit.org/changeset/78217