Bug 54200 - check-webkit-style: Add -build/include exemption for Tools/MiniBrowser/qt
Summary: check-webkit-style: Add -build/include exemption for Tools/MiniBrowser/qt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-10 05:57 PST by Zoltan Horvath
Modified: 2011-02-10 06:15 PST (History)
0 users

See Also:


Attachments
proposed patch (1.92 KB, patch)
2011-02-10 05:58 PST, Zoltan Horvath
kling: review-
Details | Formatted Diff | Diff
proposed patch (1.90 KB, patch)
2011-02-10 06:04 PST, Zoltan Horvath
kling: review+
kling: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2011-02-10 05:57:30 PST
check-webkit-style: Add -build/include exemption for Tools/MiniBrowser/qt
Comment 1 Zoltan Horvath 2011-02-10 05:58:50 PST
Created attachment 81964 [details]
proposed patch
Comment 2 Andreas Kling 2011-02-10 06:01:11 PST
Comment on attachment 81964 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81964&action=review

> Tools/Scripts/webkitpy/style/checker_unittest.py:256
> +        assertCheck("Tools/MiniBrowser/qt/UrlLoader.cpp",
> +                    "build/include")
> +        assertNoCheck("Tools/MiniBrowser/qt/UrlLoader.cpp",
> +                    "build/include")

Ahrrm...
Comment 3 Zoltan Horvath 2011-02-10 06:04:54 PST
Created attachment 81965 [details]
proposed patch
Comment 4 Andreas Kling 2011-02-10 06:08:02 PST
Comment on attachment 81965 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81965&action=review

r=me

> Tools/Scripts/webkitpy/style/checker_unittest.py:254
> +        assertCheck("random_path.cpp",
> +                    "build/include")

We're already testing this on line 213. You can leave it out.
Comment 5 Zoltan Horvath 2011-02-10 06:15:52 PST
Thnx, done!
Committed r78215.
http://trac.webkit.org/changeset/78215