Bug 54185 - [GTK] Reset GTK' DRT's AccessibilityController to consistent value before every test
Summary: [GTK] Reset GTK' DRT's AccessibilityController to consistent value before eve...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: 53146
  Show dependency treegraph
 
Reported: 2011-02-10 02:15 PST by Mario Sanchez Prada
Modified: 2011-02-10 02:45 PST (History)
2 users (show)

See Also:


Attachments
Patch proposal (2.01 KB, patch)
2011-02-10 02:19 PST, Mario Sanchez Prada
xan.lopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2011-02-10 02:15:58 PST
The (to be) attached patch is needed to ensure the accessibility controller gets reset to a consistent value before running every test.

This is now required after having fixed bug 54116.
Comment 1 Mario Sanchez Prada 2011-02-10 02:19:09 PST
Created attachment 81939 [details]
Patch proposal

Simple patch to fix this
Comment 2 Xan Lopez 2011-02-10 02:28:29 PST
Comment on attachment 81939 [details]
Patch proposal

This makes sense to me (EWS seems unhappy about the patch though).
Comment 3 Mario Sanchez Prada 2011-02-10 02:30:53 PST
(In reply to comment #2)
> (From update of attachment 81939 [details])
> This makes sense to me (EWS seems unhappy about the patch though).

Oops, that's probably because I wrote that patch on my local branch instead of doing it on top of HEAD.

Will fix that when committing. Thanks for the review
Comment 4 Mario Sanchez Prada 2011-02-10 02:45:17 PST
Committed r78184: <http://trac.webkit.org/changeset/78184>