Bug 54185

Summary:

[GTK] Reset GTK' DRT's AccessibilityController to consistent value before every test

Product:

WebKit

Reporter:

Mario Sanchez Prada <mario>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mrobinson, xan.lopez

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Bug Depends on:

Bug Blocks:

53146

Attachments:

Description	Flags
Patch proposal	xan.lopez: review+

Description Mario Sanchez Prada 2011-02-10 02:15:58 PST

The (to be) attached patch is needed to ensure the accessibility controller gets reset to a consistent value before running every test.

This is now required after having fixed bug 54116.

Comment 1 Mario Sanchez Prada 2011-02-10 02:19:09 PST

Created attachment 81939 [details]
Patch proposal

Simple patch to fix this

Comment 2 Xan Lopez 2011-02-10 02:28:29 PST

Comment on attachment 81939 [details]
Patch proposal

This makes sense to me (EWS seems unhappy about the patch though).

Comment 3 Mario Sanchez Prada 2011-02-10 02:30:53 PST

(In reply to comment #2)
> (From update of attachment 81939 [details])
> This makes sense to me (EWS seems unhappy about the patch though).

Oops, that's probably because I wrote that patch on my local branch instead of doing it on top of HEAD.

Will fix that when committing. Thanks for the review

Comment 4 Mario Sanchez Prada 2011-02-10 02:45:17 PST

Committed r78184: <http://trac.webkit.org/changeset/78184>